Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Revert "companion for 14754: cli: move no-beefy flag to sc-cli (#2996)" #3007

Merged
merged 3 commits into from
Aug 15, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
530 changes: 266 additions & 264 deletions Cargo.lock

Large diffs are not rendered by default.

4 changes: 0 additions & 4 deletions client/cli/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -394,10 +394,6 @@ impl sc_cli::CliConfiguration for NormalizedRunCmd {
self.base.disable_grandpa()
}

fn disable_beefy(&self) -> sc_cli::Result<bool> {
self.base.disable_beefy()
}

fn rpc_max_connections(&self) -> sc_cli::Result<u32> {
self.base.rpc_max_connections()
}
Expand Down
7 changes: 3 additions & 4 deletions client/relay-chain-inprocess-interface/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ pub fn check_block_in_chain(
/// Build the Polkadot full node using the given `config`.
#[sc_tracing::logging::prefix_logs_with("Relaychain")]
fn build_polkadot_full_node(
mut config: Configuration,
config: Configuration,
parachain_config: &Configuration,
telemetry_worker_handle: Option<TelemetryWorkerHandle>,
hwbench: Option<sc_sysinfo::HwBench>,
Expand All @@ -279,14 +279,13 @@ fn build_polkadot_full_node(
(polkadot_service::IsParachainNode::FullNode, None)
};

// Disable BEEFY. It should not be required by the internal relay chain node.
config.disable_beefy = true;

let relay_chain_full_node = polkadot_service::build_full(
config,
polkadot_service::NewFullParams {
is_parachain_node,
grandpa_pause: None,
// Disable BEEFY. It should not be required by the internal relay chain node.
enable_beefy: false,
jaeger_agent: None,
telemetry_worker_handle,

Expand Down
4 changes: 0 additions & 4 deletions parachain-template/node/src/command.rs
Original file line number Diff line number Diff line change
Expand Up @@ -408,10 +408,6 @@ impl CliConfiguration<Self> for RelayChainCli {
self.base.base.disable_grandpa()
}

fn disable_beefy(&self) -> Result<bool> {
self.base.base.disable_beefy()
}

fn max_runtime_instances(&self) -> Result<Option<usize>> {
self.base.base.max_runtime_instances()
}
Expand Down
4 changes: 0 additions & 4 deletions polkadot-parachain/src/command.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1064,10 +1064,6 @@ impl CliConfiguration<Self> for RelayChainCli {
self.base.base.disable_grandpa()
}

fn disable_beefy(&self) -> Result<bool> {
self.base.base.disable_beefy()
}

fn max_runtime_instances(&self) -> Result<Option<usize>> {
self.base.base.max_runtime_instances()
}
Expand Down
4 changes: 0 additions & 4 deletions test/service/src/cli.rs
Original file line number Diff line number Diff line change
Expand Up @@ -220,10 +220,6 @@ impl CliConfiguration<Self> for RelayChainCli {
self.base.base.disable_grandpa()
}

fn disable_beefy(&self) -> CliResult<bool> {
self.base.base.disable_beefy()
}

fn max_runtime_instances(&self) -> CliResult<Option<usize>> {
self.base.base.max_runtime_instances()
}
Expand Down
1 change: 0 additions & 1 deletion test/service/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -773,7 +773,6 @@ pub fn node_config(
offchain_worker: OffchainWorkerConfig { enabled: true, indexing_enabled: false },
force_authoring: false,
disable_grandpa: false,
disable_beefy: true,
dev_key_seed: Some(key_seed),
tracing_targets: None,
tracing_receiver: Default::default(),
Expand Down