fixup! Implement separate signal and message flows (#66) #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexggh
added a commit
to paritytech/polkadot-sdk
that referenced
this pull request
Jan 29, 2024
Pulls: paritytech/orchestra#71 Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
vstakhov
reviewed
Jan 29, 2024
s0me0ne-unkn0wn
approved these changes
Jan 29, 2024
|
That sucks. Sorry about that. It would require a quick-fix release @drahnr |
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
sandreim
approved these changes
Jan 29, 2024
github-merge-queue bot
pushed a commit
to paritytech/polkadot-sdk
that referenced
this pull request
Jan 29, 2024
Pulls: paritytech/orchestra#71 --------- Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We forgot to increment signals_received, that make subsystems to fall out of sync if they start using recv_signal, which we did in paritytech/polkadot-sdk#2125 and that made roco to slow-down significantly.