Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements for transaction refundability checks #2730

Closed
3 tasks
svyatonik opened this issue Dec 6, 2023 · 0 comments · Fixed by paritytech/polkadot-sdk#4549
Closed
3 tasks

Improvements for transaction refundability checks #2730

svyatonik opened this issue Dec 6, 2023 · 0 comments · Fixed by paritytech/polkadot-sdk#4549
Labels
A-feat New feature or request P-Relay
Milestone
Nice To Have

Comments

@svyatonik
Copy link
Contributor

#2729 introduces new check to the relay - now it'll try to select such header+proof for delivery/confirmation (batch) transactions, so that it'll be under refundable limit => relayer has a guarantee that it won't lose his funds. However, it is implemented only for the on-demand relay with batch transactions. We do not need it for non-batch relays and/or regular (non-on-demand) relays atm, but we may in the future. So this issue is about:

  • adding similar checks to the regular non-on-demand relays;
  • adding similar checks to on-demand relays that are not using batch transactions;
  • maybe adding similar check for maximal weight.
@svyatonik svyatonik added A-feat New feature or request P-Relay labels Dec 6, 2023
@svyatonik svyatonik added this to the Nice To Have milestone Dec 6, 2023
@svyatonik svyatonik mentioned this issue Dec 6, 2023
Merged
3 tasks
This was referenced May 22, 2024
Closed
Merged
github-merge-queue bot pushed a commit to paritytech/polkadot-sdk that referenced this issue May 27, 2024
@svyatonik
Bridge: check submit_finality_proof limits before submission (#4549)
f6cca7e 
closes paritytech/parity-bridges-common#2982
closes paritytech/parity-bridges-common#2730

The main change is in the
bridges/relays/lib-substrate-relay/src/finality/target.rs, changes in
other files are just moving the code

~I haven't been able to run zn tests locally - don't know why, but it
keeps failing for me locally with: `
Error running script:
/home/svyatonik/dev/polkadot-sdk/bridges/testing/framework/js-helpers/wait-hrmp-channel-opened.js
Error: Timeout(300), "custom-js
/home/svyatonik/dev/polkadot-sdk/bridges/testing/framework/js-helpers/wait-hrmp-channel-opened.js
within 300 secs" didn't complete on time.`~ The issue was an obsolete
`polkadot-js-api` binary - did `yarn global upgrade` and it is ok now
hitchhooker pushed a commit to ibp-network/polkadot-sdk that referenced this issue Jun 5, 2024
@svyatonik @hitchhooker
Bridge: check submit_finality_proof limits before submission (parityt…
e629d5a 
…ech#4549)

closes paritytech/parity-bridges-common#2982
closes paritytech/parity-bridges-common#2730

The main change is in the
bridges/relays/lib-substrate-relay/src/finality/target.rs, changes in
other files are just moving the code

~I haven't been able to run zn tests locally - don't know why, but it
keeps failing for me locally with: `
Error running script:
/home/svyatonik/dev/polkadot-sdk/bridges/testing/framework/js-helpers/wait-hrmp-channel-opened.js
Error: Timeout(300), "custom-js
/home/svyatonik/dev/polkadot-sdk/bridges/testing/framework/js-helpers/wait-hrmp-channel-opened.js
within 300 secs" didn't complete on time.`~ The issue was an obsolete
`polkadot-js-api` binary - did `yarn global upgrade` and it is ok now
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this issue Aug 2, 2024
@svyatonik @TarekkMA
Bridge: check submit_finality_proof limits before submission (parityt…
95ea631 
…ech#4549)

closes paritytech/parity-bridges-common#2982
closes paritytech/parity-bridges-common#2730

The main change is in the
bridges/relays/lib-substrate-relay/src/finality/target.rs, changes in
other files are just moving the code

~I haven't been able to run zn tests locally - don't know why, but it
keeps failing for me locally with: `
Error running script:
/home/svyatonik/dev/polkadot-sdk/bridges/testing/framework/js-helpers/wait-hrmp-channel-opened.js
Error: Timeout(300), "custom-js
/home/svyatonik/dev/polkadot-sdk/bridges/testing/framework/js-helpers/wait-hrmp-channel-opened.js
within 300 secs" didn't complete on time.`~ The issue was an obsolete
`polkadot-js-api` binary - did `yarn global upgrade` and it is ok now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-feat New feature or request P-Relay
Projects
None yet
Milestone
Nice To Have
Development

Successfully merging a pull request may close this issue.

Bridge: check submit_finality_proof limits before submission paritytech/polkadot-sdk
1 participant
@svyatonik