Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport latest changes from polkadot staging #2732

Merged
merged 5 commits into from
Dec 8, 2023

Conversation

svyatonik
Copy link
Contributor

Looks like new relayer works ok - still going to watch it for another couple of days.

@bkontur I'm not porting #2727, because you've said it is already a port from master :) But if you need something from there in master, please point - I'll port it too

* separate constants for average and worst case relay headers

* fix compilation
… relay (#2729)

* select header that will be fully refunded for submission in on-demand **batch** finality relay

* added the only possible test

* spelling

* nl

* updated comment
@svyatonik svyatonik added the A-chores Something that has to be done, as part of regular maintenance label Dec 8, 2023
@bkontur
Copy link
Contributor

bkontur commented Dec 8, 2023

yes, I have just small nits:

https://github.com/paritytech/parity-bridges-common/pull/2727/files#diff-1059dbc95faa4274ddbe6051c6b0c66a8e297dbbf799ce2867884dd904db2277R5-R6

https://github.com/paritytech/parity-bridges-common/pull/2727/files#diff-9aac78fe025db5c4ca23686baaf581f1c9cdcd279cf8bd673fdec734ce646312R5-R6

and I would move this bridgeId/laneId check:
https://github.com/paritytech/parity-bridges-common/blob/master/modules/xcm-bridge-hub/src/exporter.rs#L88-L98
before PalletAsHaulBlobExporter::<T, I>::validate( and change Unroutable to NotAplicable -> if we dont have configuration for (source, dest), maybe we could have another instance for the same BridgedNetwork and give it a try, we dont need to be strict here and say "we dont allow only one instance for the same BridgedNetwork`

@svyatonik
Copy link
Contributor Author

yes, I have just small nits:

https://github.com/paritytech/parity-bridges-common/pull/2727/files#diff-1059dbc95faa4274ddbe6051c6b0c66a8e297dbbf799ce2867884dd904db2277R5-R6

https://github.com/paritytech/parity-bridges-common/pull/2727/files#diff-9aac78fe025db5c4ca23686baaf581f1c9cdcd279cf8bd673fdec734ce646312R5-R6

and I would move this bridgeId/laneId check: https://github.com/paritytech/parity-bridges-common/blob/master/modules/xcm-bridge-hub/src/exporter.rs#L88-L98 before PalletAsHaulBlobExporter::<T, I>::validate( and change Unroutable to NotAplicable -> if we dont have configuration for (source, dest), maybe we could have another instance for the same BridgedNetwork and give it a try, we dont need to be strict here and say "we dont allow only one instance for the same BridgedNetwork`

Ok, done. Thank you!

@bkontur
Copy link
Contributor

bkontur commented Dec 8, 2023

and this #2733 :)

@svyatonik svyatonik merged commit ea6a787 into master Dec 8, 2023
13 checks passed
@svyatonik svyatonik deleted the backport-from-polkadot-staging branch December 8, 2023 10:12
bkontur added a commit that referenced this pull request May 7, 2024
* separate constants for average and worst case relay headers (#2728)

* separate constants for average and worst case relay headers

* fix compilation

* Select header that will be fully refunded in on-demand batch finality relay (#2729)

* select header that will be fully refunded for submission in on-demand **batch** finality relay

* added the only possible test

* spelling

* nl

* updated comment

* backport some nits from #2727

* NotApplicable instead of Unroutable

* Grafana update stuff (#2733)

---------

Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-chores Something that has to be done, as part of regular maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants