-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rocksdb Secondary Instance Api #384
Conversation
This reverts commit ace87ee.
* master: Fix limit prefix delete case (paritytech#368) Add arbitrary trait implementation (paritytech#378)
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: Andronik Ordian <write@reusable.software>
Co-Authored-By: David <dvdplm@gmail.com>
Co-Authored-By: David <dvdplm@gmail.com>
…ipx/secondary-reader
Co-Authored-By: David <dvdplm@gmail.com>
Co-authored-by: Andronik Ordian <write@reusable.software>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good modulo unresolved comments.
Yeah still investigating how exactly Rocksdb handles secondary connections, but should be resolved sometime today |
expand on what `try_catch_up_with_secondary` does, since it may have some implications on the primary instance of rocksdb according to L503-566 in `db/db_impl/db_impl_secondary.cc` of facebook/rocksdb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, good job here. :)
* master: (56 commits) primitive-types: add no_std support for serde feature (#385) Add Rocksdb Secondary Instance Api (#384) kvdb-rocksdb: update rocksdb to 0.14 (#379) prepare releases for a few crates (#382) uint: fix UB in uint::from_big_endian (#381) Fix limit prefix delete case (#368) Add arbitrary trait implementation (#378) kvdb-rocksdb: optimize and rename iter_from_prefix (#365) bump parity-util-mem (#376) parity-util-mem: fix for windows (#375) keccak-hash: fix bench and add one for range (#372) [parity-crypto] Release 0.6.1 (#373) keccak-hash: bump version to 0.5.1 (#371) keccak-hash: add keccak256_range and keccak512_range functions (#370) Allow pubkey recovery for all-zero messages (#369) Delete by prefix operator in kvdb (#360) kvdb: no overlay (#313) Ban duplicates of parity-uil-mem from being linked into the same program (#363) Use correct license ID (#362) Memtest example for Rocksdb (#349) ...
This PR adds rocksdb
open_as_secondary
api added inrust-rocksdb
0.14 to the paritykvdb-rocksdb
crateuseful for reading from rocksdb while a node is running
blocked on #379Secondary API RocksDB Docs: https://github.com/facebook/rocksdb/wiki/Secondary-instance