Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for release 2.3.1 #294

Merged
merged 5 commits into from
Sep 28, 2021
Merged

Prepare for release 2.3.1 #294

merged 5 commits into from
Sep 28, 2021

Conversation

Robbepop
Copy link
Contributor

  • Write changelog
  • Bump crate versions from 2.3.0 to 2.3.1.

Cargo.toml Show resolved Hide resolved
Copy link
Contributor

@gui1117 gui1117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge and publish once CI is done

@Robbepop
Copy link
Contributor Author

Robbepop commented Sep 28, 2021

A run of cargo outdated -vvv shows that quite a few dependencies are outdated.
Amongst others the bitvec crate that caused problems has had 2 new minor version updates.
We could push out another minor version after this patch version with the updated dependencies. What do you think about this?

Name                                              Project  Compat   Latest   Kind    Platform
----                                              -------  ------   ------   ----    --------
atty->libc                                        0.2.101  0.2.103  0.2.103  Normal  cfg(unix)
bitvec                                            0.20.4   ---      0.22.3   Normal  ---
bitvec->funty                                     1.1.0    ---      1.2.0    Normal  ---
bitvec->wyz                                       0.2.0    ---      0.4.0    Normal  ---
byte-slice-cast                                   1.0.0    1.1.0    1.1.0    Normal  ---
clap->unicode-width                               0.1.8    0.1.9    0.1.9    Normal  ---
criterion->serde_json                             1.0.67   1.0.68   1.0.68   Normal  ---
csv->bstr                                         0.2.16   0.2.17   0.2.17   Normal  ---
derive_arbitrary->syn                             1.0.76   1.0.77   1.0.77   Normal  ---
getrandom->libc                                   0.2.101  0.2.103  0.2.103  Normal  cfg(unix)
hermit-abi->libc                                  0.2.101  0.2.103  0.2.103  Normal  ---
impl-trait-for-tuples->syn                        1.0.76   1.0.77   1.0.77   Normal  ---
js-sys->wasm-bindgen                              0.2.77   0.2.78   0.2.78   Normal  ---
num_cpus->libc                                    0.2.101  0.2.103  0.2.103  Normal  ---
parity-scale-codec-derive->proc-macro-crate       1.0.0    1.1.0    1.1.0    Normal  ---
parity-scale-codec-derive->syn                    1.0.76   1.0.77   1.0.77   Normal  ---
plotters->wasm-bindgen                            0.2.77   0.2.78   0.2.78   Normal  cfg(target_arch = "wasm32")
plotters->web-sys                                 0.3.54   0.3.55   0.3.55   Normal  cfg(target_arch = "wasm32")
serde_derive->syn                                 1.0.76   1.0.77   1.0.77   Normal  ---
textwrap->unicode-width                           0.1.8    0.1.9    0.1.9    Normal  ---
thiserror-impl->syn                               1.0.76   1.0.77   1.0.77   Normal  ---
tinytemplate->serde_json                          1.0.67   1.0.68   1.0.68   Normal  ---
trybuild->serde_json                              1.0.67   1.0.68   1.0.68   Normal  ---
wasm-bindgen->wasm-bindgen-macro                  0.2.77   0.2.78   0.2.78   Normal  ---
wasm-bindgen-backend->bumpalo                     3.7.0    3.7.1    3.7.1    Normal  ---
wasm-bindgen-backend->syn                         1.0.76   1.0.77   1.0.77   Normal  ---
wasm-bindgen-backend->wasm-bindgen-shared         0.2.77   0.2.78   0.2.78   Normal  ---
wasm-bindgen-macro->wasm-bindgen-macro-support    0.2.77   0.2.78   0.2.78   Normal  ---
wasm-bindgen-macro-support->syn                   1.0.76   1.0.77   1.0.77   Normal  ---
wasm-bindgen-macro-support->wasm-bindgen-backend  0.2.77   0.2.78   0.2.78   Normal  ---
wasm-bindgen-macro-support->wasm-bindgen-shared   0.2.77   0.2.78   0.2.78   Normal  ---
web-sys->js-sys                                   0.3.54   0.3.55   0.3.55   Normal  ---
web-sys->wasm-bindgen                             0.2.77   0.2.78   0.2.78   Normal  ---

All of these boil down to a single cargo update and shifting the dependency of bitvec to version 0.22.3.
However, updating bitvec yields tons of compile errors. Seems like non trivial work.

@gui1117
Copy link
Contributor

gui1117 commented Sep 28, 2021

I feel like for binaries it makes sense to have no outdated compatible version, but for libraries I think there is no need to be always with the latest compatible version, our library parity_scale_codec support both byte_slice_cast 1.0.0 and 1.1.0 there is no need to force our user to use byte_slice_cast 1.1.0 it is their choice to use any of the version.

That said maybe it is a good practice to do it anyway so that our test suite is run against the latest version.

For bitvec we are on the latest compatible version, and as we use it publicly (we implement codec on some of its type) then upgrading to a new major version is a breaking change and I would prefer not to release parity_scale_codec major version at the same (quite fast) rate as bitvec.
Maybe it is possible to implement multiple version with new feature (like we create a new feature bitvec-0-22) but feature in rust being usually annoying and limited (no feature on optional dependency etc..) I'm not sure it worth the pain.

To conclude I think it is not needed

@gui1117 gui1117 merged commit a27e494 into master Sep 28, 2021
@gui1117 gui1117 deleted the robin-write-changelog-2.3.1 branch September 28, 2021 17:09
@gui1117
Copy link
Contributor

gui1117 commented Sep 28, 2021

published with tags :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants