move json-file to common args #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koute
reviewed
Oct 8, 2022
| @@ -27,6 +27,7 @@ bench_pallet_common_args=( | |||
| --execution=wasm | |||
| --wasm-execution=compiled | |||
| --heap-pages=4096 | |||
| --json-file="${ARTIFACTS_DIR}/bench.json" | |||
There was a problem hiding this comment.
If multiple pallets are queued won't this just keep only the result for the last pallet?
There was a problem hiding this comment.
There was a problem hiding this comment.
You can currently only benchmark one pallet at a time with this command.
The exception is that when that pallet has multiple instances, in which case it would behave the same as it does now (but I dont know how).
ggwpez
approved these changes
Oct 10, 2022
koute
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix paritytech/command-bot#107