Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CheckNonce should refuse transactions signed by accounts with no providers #1453

Open
zdave-parity opened this issue Sep 7, 2023 · 0 comments
Open

CheckNonce should refuse transactions signed by accounts with no providers #1453

zdave-parity opened this issue Sep 7, 2023 · 0 comments
Labels
I10-unconfirmed Issue might be valid, but it's not yet known.

Comments

@zdave-parity
Copy link
Contributor

zdave-parity commented Sep 7, 2023 •
edited
Loading

As it stores nonces in frame_system::Account. This wouldn't make any difference on chains with transaction fees (if an account has a balance to pay a transaction fee, this balance would also count as a provider). Some chains don't have balances and transaction fees though, eg the Polkadot Bulletin Chain. As it stands this change wouldn't make any difference to the Bulletin Chain either, due to the custom SignedExtension. It seems like a sensible "belt and braces" change to make though?
@github-actions github-actions bot added the I10-unconfirmed Issue might be valid, but it's not yet known. label Sep 7, 2023
@zdave-parity zdave-parity mentioned this issue Sep 14, 2023
Merged
bkchr added a commit that referenced this issue Oct 10, 2023
@zdave-parity @bkchr
Make CheckNonce refuse transactions signed by accounts with no provid…
93d9c8c 
…ers (#1578)

See #1453.

Co-authored-by: Bastian Köcher <git@kchr.de>
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this issue Mar 25, 2024
@zdave-parity @bkchr
Make CheckNonce refuse transactions signed by accounts with no provid…
60e6c5e 
…ers (paritytech#1578)

See paritytech#1453.

Co-authored-by: Bastian Köcher <git@kchr.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I10-unconfirmed Issue might be valid, but it's not yet known.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zdave-parity