Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[syncing] Trigger block import by hash instead of number #1778

Open
dmitry-markin opened this issue Oct 3, 2023 · 0 comments
Open

[syncing] Trigger block import by hash instead of number #1778

dmitry-markin opened this issue Oct 3, 2023 · 0 comments

Comments

@dmitry-markin
Copy link
Contributor

#1686 fixes an issue with failed imports of forks #493 when import is erroneously triggered by block number comparison instead of parent hash comparison (see #493 (comment)). This leads to the syncing state machine believing it can extend the canonical chain, while in reality blocks belong to a fork and cannot be imported (and we need a few more blocks downloaded backwards in order to reach the forking point). This wouldn't be happening if import was triggered by parent hash comparison instead of merely block number comparison.

The fix #1686 is fine short-term, but in the long term the logic must be updated to trigger import by parent hash comparison instead of block number comparison. This issue is about implementing this logic and obsoleting #1686.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog 🗒
Development

No branches or pull requests

1 participant