Upgrade to Substrate fork version that reverts node sync fix #2138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazar-pc
requested review from
vedhavyas,
NingLin-P and
rg3l3dr
as code owners
rahulksnv
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
LGTM thanks.
I will let the upstream folks know the findings from last 2 days.
To be clear, the scenario that paritytech/polkadot-sdk#1812 addresses is still relevant, and nodes will get stuck if they get into that situation. But fixing that gets us into trouble with a different scenario (ongoing reorg in the network while the node is catching up: #2122). Guess the latter is more likely to happen, so reverting 1812 makes sense
|
Yes, the only reason to revert here is that new issue is happening more frequently. We definitely want to fix both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This imports autonomys/polkadot-sdk@892bf8e and corresponding autonomys/frontier#4 to revert paritytech/polkadot-sdk#1812 in order to not have #2122 until we know how to fix it.
There are a few potentially relevant upstream issues I'm now following:
ChainSyncrequesting the same block multiple times paritytech/polkadot-sdk#1915Code contributor checklist: