Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release chain-spec-builder #4352

Closed
xlc opened this issue May 2, 2024 · 6 comments · Fixed by #4518
Closed

release chain-spec-builder #4352

xlc opened this issue May 2, 2024 · 6 comments · Fixed by #4518

Comments

@xlc
Copy link
Contributor

xlc commented May 2, 2024

so I can cargo install it and use it
@bkchr
Copy link
Member

bkchr commented May 2, 2024

CC @Morganamilo

@kianenigma
Copy link
Contributor

kianenigma commented May 10, 2024 •
edited
Loading

This is quite important for #3944 #3597 and related, so that we can only work with chain spec files in an easy way.

@Polkadot-Forum
Copy link

This issue has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-parachain-omni-node-gathering-ideas-and-feedback/7823/1

@Polkadot-Forum
Copy link

This issue has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-parachain-omni-node-gathering-ideas-and-feedback/7823/5

@kianenigma kianenigma mentioned this issue May 14, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue May 14, 2024
@kianenigma @bkontur
make polkadot-parachain chain-spec extension more relaxed (#4452)
12ab315 
A small step towards
https://forum.polkadot.network/t/polkadot-parachain-omni-node-gathering-ideas-and-feedback/7823
and #4352.

Many parachains use `camelCase` and/or `PascalCase`ing for their chain
spec extension. Sometimes the only reason polkadot-parachain cannot sync
them is because it cannot parse the chain spec extension. This PR
relaxes the requirement for the extension to be camel case.

---------

Co-authored-by: Branislav Kontur <bkontur@gmail.com>
@kianenigma kianenigma mentioned this issue May 20, 2024
Merged
1 task
@bkontur bkontur mentioned this issue May 24, 2024
Merged
4 tasks
github-merge-queue bot pushed a commit that referenced this issue May 29, 2024
@kianenigma @bkontur
Publish chain-spec-builder (#4518)
dfcfa4a 
marking it as release-able, attaching the same version number that is
attached to other binaries such as `polkadot` and `polkadot-parachain`.

I have more thoughts about the version number, though. The chain-spec
builder is mainly a user of the `sp-genesis-builder` api. So the
versioning should be such that it helps users know give a version of
`sp-genesis-builder` in their runtime, which version of
`chain-spec-builder` should they use?

With this, we can possibly alter the version number to always match
`sp-genesis-builder`.

Fixes #4352

- [x] Add to release artifacts ~~similar to
#4405 done here:
#4557

---------

Co-authored-by: Branislav Kontur <bkontur@gmail.com>
EgorPopelyaev pushed a commit that referenced this issue May 30, 2024
@kianenigma @bkontur @EgorPopelyaev
Publish chain-spec-builder (#4518)
9970c63 
marking it as release-able, attaching the same version number that is
attached to other binaries such as `polkadot` and `polkadot-parachain`.

I have more thoughts about the version number, though. The chain-spec
builder is mainly a user of the `sp-genesis-builder` api. So the
versioning should be such that it helps users know give a version of
`sp-genesis-builder` in their runtime, which version of
`chain-spec-builder` should they use?

With this, we can possibly alter the version number to always match
`sp-genesis-builder`.

Fixes #4352

- [x] Add to release artifacts ~~similar to
#4405 done here:
#4557

---------

Co-authored-by: Branislav Kontur <bkontur@gmail.com>
EgorPopelyaev pushed a commit that referenced this issue May 30, 2024
@kianenigma @bkontur @EgorPopelyaev
Publish chain-spec-builder (#4518)
afd8337 
marking it as release-able, attaching the same version number that is
attached to other binaries such as `polkadot` and `polkadot-parachain`.

I have more thoughts about the version number, though. The chain-spec
builder is mainly a user of the `sp-genesis-builder` api. So the
versioning should be such that it helps users know give a version of
`sp-genesis-builder` in their runtime, which version of
`chain-spec-builder` should they use?

With this, we can possibly alter the version number to always match
`sp-genesis-builder`.

Fixes #4352

- [x] Add to release artifacts ~~similar to
#4405 done here:
#4557

---------

Co-authored-by: Branislav Kontur <bkontur@gmail.com>
@bkontur
Copy link
Contributor

bkontur commented May 30, 2024

@xlc you can now cargo install:

$ cargo install staging-chain-spec-builder
$ chain-spec-builder -h
A utility to easily create a chain spec definition

Usage: chain-spec-builder [OPTIONS] <COMMAND>

Commands:
  create          Create a new chain spec by interacting with the provided runtime wasm blob
  verify          Verifies the provided input chain spec
  update-code     Updates the code in the provided input chain spec
  convert-to-raw  Converts the given chain spec into the raw format
  list-presets    Lists available presets
  display-preset  Displays given preset
  help            Print this message or the help of the given subcommand(s)

Options:
  -c, --chain-spec-path <CHAIN_SPEC_PATH>
          The path where the chain spec should be saved [default: ./chain_spec.json]
  -h, --help
          Print help

@kianenigma
Copy link
Contributor

Nice, thank you @bkontur @EgorPopelyaev!

hitchhooker pushed a commit to ibp-network/polkadot-sdk that referenced this issue Jun 5, 2024
@kianenigma @bkontur @hitchhooker
make polkadot-parachain chain-spec extension more relaxed (paritytech…
829fa43 
…#4452)

A small step towards
https://forum.polkadot.network/t/polkadot-parachain-omni-node-gathering-ideas-and-feedback/7823
and paritytech#4352.

Many parachains use `camelCase` and/or `PascalCase`ing for their chain
spec extension. Sometimes the only reason polkadot-parachain cannot sync
them is because it cannot parse the chain spec extension. This PR
relaxes the requirement for the extension to be camel case.

---------

Co-authored-by: Branislav Kontur <bkontur@gmail.com>
hitchhooker pushed a commit to ibp-network/polkadot-sdk that referenced this issue Jun 5, 2024
@kianenigma @bkontur @hitchhooker
Publish chain-spec-builder (paritytech#4518)
f8dd3dc 
marking it as release-able, attaching the same version number that is
attached to other binaries such as `polkadot` and `polkadot-parachain`.

I have more thoughts about the version number, though. The chain-spec
builder is mainly a user of the `sp-genesis-builder` api. So the
versioning should be such that it helps users know give a version of
`sp-genesis-builder` in their runtime, which version of
`chain-spec-builder` should they use?

With this, we can possibly alter the version number to always match
`sp-genesis-builder`.

Fixes paritytech#4352

- [x] Add to release artifacts ~~similar to
paritytech#4405 done here:
paritytech#4557

---------

Co-authored-by: Branislav Kontur <bkontur@gmail.com>
liuchengxu pushed a commit to liuchengxu/polkadot-sdk that referenced this issue Jun 19, 2024
@kianenigma @bkontur @liuchengxu
make polkadot-parachain chain-spec extension more relaxed (paritytech…
206c06b 
…#4452)

A small step towards
https://forum.polkadot.network/t/polkadot-parachain-omni-node-gathering-ideas-and-feedback/7823
and paritytech#4352.

Many parachains use `camelCase` and/or `PascalCase`ing for their chain
spec extension. Sometimes the only reason polkadot-parachain cannot sync
them is because it cannot parse the chain spec extension. This PR
relaxes the requirement for the extension to be camel case.

---------

Co-authored-by: Branislav Kontur <bkontur@gmail.com>
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this issue Aug 2, 2024
@kianenigma @bkontur @TarekkMA
make polkadot-parachain chain-spec extension more relaxed (paritytech…
fa2aeaf 
…#4452)

A small step towards
https://forum.polkadot.network/t/polkadot-parachain-omni-node-gathering-ideas-and-feedback/7823
and paritytech#4352.

Many parachains use `camelCase` and/or `PascalCase`ing for their chain
spec extension. Sometimes the only reason polkadot-parachain cannot sync
them is because it cannot parse the chain spec extension. This PR
relaxes the requirement for the extension to be camel case.

---------

Co-authored-by: Branislav Kontur <bkontur@gmail.com>
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this issue Aug 2, 2024
@kianenigma @bkontur @TarekkMA
Publish chain-spec-builder (paritytech#4518)
3fedbd6 
marking it as release-able, attaching the same version number that is
attached to other binaries such as `polkadot` and `polkadot-parachain`.

I have more thoughts about the version number, though. The chain-spec
builder is mainly a user of the `sp-genesis-builder` api. So the
versioning should be such that it helps users know give a version of
`sp-genesis-builder` in their runtime, which version of
`chain-spec-builder` should they use?

With this, we can possibly alter the version number to always match
`sp-genesis-builder`.

Fixes paritytech#4352

- [x] Add to release artifacts ~~similar to
paritytech#4405 done here:
paritytech#4557

---------

Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Publish chain-spec-builder paritytech/polkadot-sdk
5 participants
@xlc @kianenigma @bkchr @bkontur @Polkadot-Forum