Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct target dir in polkadot readme #1643

Merged
merged 4 commits into from
Sep 22, 2023
Merged

Use correct target dir in polkadot readme #1643

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e79411b
Use correct target dir in description
skunert Sep 20, 2023
81e9410
Clean up some more
skunert Sep 20, 2023
879b92d
Make linter happy
skunert Sep 20, 2023
1429f97
Improve wording and make linter happy
skunert Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions polkadot/README.md
View file
Open in desktop
ggwpez marked this conversation as resolved.
Show resolved Hide resolved
skunert marked this conversation as resolved.
Show resolved Hide resolved
skunert marked this conversation as resolved.
Show resolved Hide resolved
skunert marked this conversation as resolved.
Show resolved Hide resolved
skunert marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curl https://getsubstrate.io -sSf | bash -s -- --fast

DQ but do you know where / how this is maintained? It mentions the old Substrate repo in the code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea. In the substrate README we are linking to https://docs.substrate.io/install/, which is probably a good idea here too, since the build environment and requirements for polkadot should not be different from what is described there. This getsubstrate stuff can be removed then.

skunert marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ This repo supports runtimes for Polkadot, Kusama, and Westend.
Connect to the global Polkadot Mainnet network by running:

```bash
./target/release/polkadot --chain=polkadot
../target/release/polkadot --chain=polkadot
```

You can see your node on [telemetry] (set a custom name with `--name "my custom name"`).
Expand All @@ -135,7 +135,7 @@ You can see your node on [telemetry] (set a custom name with `--name "my custom
Connect to the global Kusama canary network by running:

```bash
./target/release/polkadot --chain=kusama
../target/release/polkadot --chain=kusama
```

You can see your node on [telemetry] (set a custom name with `--name "my custom name"`).
Expand All @@ -147,7 +147,7 @@ You can see your node on [telemetry] (set a custom name with `--name "my custom
Connect to the global Westend testnet by running:

```bash
./target/release/polkadot --chain=westend
../target/release/polkadot --chain=westend
```

You can see your node on [telemetry] (set a custom name with `--name "my custom name"`).
Expand Down