Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove (rococo/westend)-runtime deps from testnet AssetHubs #1979

Merged
merged 4 commits into from
Oct 23, 2023

Conversation

bkontur
Copy link
Contributor

@bkontur bkontur commented Oct 23, 2023

Problem

This PR addresses the issue with testnet AssetHub builds, which was discovered during the execution of bot bench.

https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4038738

     Compiling asset-hub-rococo-runtime-wasm v1.0.0 (/builds/parity/mirrors/polkadot-sdk/target/production/wbuild/asset-hub-rococo-runtime)
  warning: Linking globals named 'Core_version': symbol multiply defined!
  error: failed to load bitcode of module "rococo_runtime-8799ee884447805a.rococo_runtime.0bc572b8-cgu.0.rcgu.o": 
  warning: `asset-hub-rococo-runtime-wasm` (lib) generated 1 warning
  error: could not compile `asset-hub-rococo-runtime-wasm` (lib) due to previous error; 1 warning emitted

https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4038739

Compiling asset-hub-westend-runtime-wasm v1.0.0 (/builds/parity/mirrors/polkadot-sdk/target/production/wbuild/asset-hub-westend-runtime)
  warning: Linking globals named 'Core_version': symbol multiply defined!
  error: failed to load bitcode of module "westend_runtime-86d7844430f97d5c.westend_runtime.b7678d03-cgu.0.rcgu.o": 
  warning: `asset-hub-westend-runtime-wasm` (lib) generated 1 warning
  error: could not compile `asset-hub-westend-runtime-wasm` (lib) due to previous error; 1 warning emitted

Solution

  • Removed dependencies on rococo-runtime and westend-runtime introduced by this PR.
  • Replaced <rococo_runtime::Treasury as PalletInfoAccess>::index() with rococo_runtime_constants::TREASURY_PALLET_ID.
  • Added check_treasury_pallet_id to the relay runtimes to ensure that the constant is aligned with the pallet id.
  • Added "Rococo Treasury" to the waived locations (that will not be charged fees in the executor) for BridgeHubRococo (to be aligned with AssetHubs).

References

Full element discussion here.

@bkontur bkontur added the T9-cumulus This PR/Issue is related to cumulus. label Oct 23, 2023
@bkontur
Copy link
Contributor Author

bkontur commented Oct 23, 2023

bot bench cumulus-bridge-hubs --runtime=bridge-hub-rococo --pallet=pallet_bridge_relayers

@command-bot
Copy link

command-bot bot commented Oct 23, 2023

@bkontur https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4043483 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=bridge-hub-rococo --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_bridge_relayers. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 24-d5ba7c7e-6c11-4c3e-a66c-22fa43a446a7 to cancel this command or bot cancel to cancel all commands in this pull request.

Copy link
Contributor

@seadanda seadanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Edit: query has already been resolved.

@bkontur bkontur requested a review from bkchr October 23, 2023 08:43
…=bridge-hub-rococo --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_bridge_relayers
@command-bot
Copy link

command-bot bot commented Oct 23, 2023

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=bridge-hub-rococo --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_bridge_relayers has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4043483 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4043483/artifacts/download.

Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty!

@bkchr bkchr enabled auto-merge (squash) October 23, 2023 10:02
@bkchr bkchr merged commit c284a93 into master Oct 23, 2023
112 of 113 checks passed
@bkchr bkchr deleted the bko-remove-runtime-deps-from-asset-hubs branch October 23, 2023 10:22
bkontur added a commit to bkontur/runtimes that referenced this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T9-cumulus This PR/Issue is related to cumulus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants