Change pallet referenda TracksInfo::tracks to return an iterator #2072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
reviewed
Oct 28, 2023
olanod
force-pushed
the
olanod-referenda-owned-tracks
branch
from
b059f67
to
4bc9edc
Compare
|
NOTE: I realized that return_position_impl_trait_in_trait was recently stabilized, I think it's worth using it in this feature as it makes usage of the trait much simpler. Please consider updating the rust toolchain :) EDIT: As the policy is to keep things working with stable Rust, I reverted the usage of the nightly feature( |
olanod
force-pushed
the
olanod-referenda-owned-tracks
branch
from
5c3ab3b
to
57585ac
Compare
olanod
force-pushed
the
olanod-referenda-owned-tracks
branch
3 times, most recently
from
50a8759
to
355615d
Compare
olanod
force-pushed
the
olanod-referenda-owned-tracks
branch
3 times, most recently
from
c3abd5b
to
e1a2699
Compare
olanod
force-pushed
the
olanod-referenda-owned-tracks
branch
4 times, most recently
from
4994d7e
to
47c9710
Compare
olanod
force-pushed
the
olanod-referenda-owned-tracks
branch
2 times, most recently
from
750f1bb
to
e0d4e7c
Compare
olanod
force-pushed
the
olanod-referenda-owned-tracks
branch
from
e0d4e7c
to
e37fe07
Compare
ggwpez
reviewed
Feb 21, 2024
cumulus/parachains/runtimes/collectives/collectives-westend/src/fellowship/tracks.rs
Outdated
Show resolved
Hide resolved
ggwpez
reviewed
Feb 21, 2024
ggwpez
reviewed
Feb 21, 2024
ggwpez
reviewed
Feb 21, 2024
cumulus/parachains/runtimes/collectives/collectives-polkadot/src/ambassador/tracks.rs
Outdated
Show resolved
Hide resolved
olanod
force-pushed
the
olanod-referenda-owned-tracks
branch
from
2e23b83
to
6a877dc
Compare
muharem
reviewed
Mar 18, 2024
There was a problem hiding this comment.
Looks good.
Since the motivation for these changes is to provide an option for setting tracks within the storage, and as these changes are breaking changes, it would be nice to have such a setup as an example and proof of concept to ensure we're not missing anything. For example, you could try setting it up for the kitchensink-runtime runtime with the parameters pallet.
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Mar 26, 2024
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Mar 27, 2024
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 10, 2024
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 10, 2024
bkchr
pushed a commit
that referenced
this pull request
Apr 10, 2024
|
@muharem the feature is working, this week we released pallet-communities in Kreivo which allows DAOs to make use of the pallet-referenda infrastructure and set-up/configure their own tracks dynamically with pallet-referenda-tracks implemented by @pandres95 |
|
@olanod to have a setup example would be still good |
Using an iterator instead of a static slice allows for more flexible implementations of `TracksInfo` that can use the chain storage without compromising a lot on the performance/memory penalty if we were to return an owned `Vec` instead.
olanod
force-pushed
the
olanod-referenda-owned-tracks
branch
from
ce4ec43
to
3503e9c
Compare
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returning an iterator in
TracksInfo::tracks()instead of a static slice allows for more flexible implementations ofTracksInfothat can use the chain storage without compromising a lot on the performance/memory penalty if we were to return an ownedVecinstead.