Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a deprecation section to the Contributing notes #2248

Merged
merged 7 commits into from
Dec 12, 2023
Merged

Add a deprecation section to the Contributing notes #2248

merged 7 commits into from
Dec 12, 2023

Conversation

juangirini
Copy link
Contributor

A brief explanation of the Deprecation Checklist is added to the Contributing notes with a link to it

@juangirini juangirini added the T11-documentation This PR/Issue is related to documentation. label Nov 9, 2023
@juangirini juangirini requested review from a team and removed request for a team November 9, 2023 10:47
davxy
davxy reviewed Nov 9, 2023
View reviewed changes
docs/CONTRIBUTING.md Outdated Show resolved Hide resolved
@juangirini juangirini requested a review from davxy November 9, 2023 11:51
@juangirini juangirini marked this pull request as draft November 10, 2023 09:42
@juangirini juangirini added the R0-silent Changes should not be mentioned in any release notes label Dec 5, 2023
@juangirini juangirini self-assigned this Dec 5, 2023
@juangirini juangirini marked this pull request as ready for review December 5, 2023 09:43
@juangirini juangirini requested review from muharem and a team December 5, 2023 09:49
@juangirini juangirini merged commit 6b5995f into master Dec 12, 2023
126 of 128 checks passed
@juangirini juangirini deleted the jg/add-deprecation-checklist-link branch December 12, 2023 13:24
@github-actions github-actions bot mentioned this pull request Feb 19, 2024
Closed
@github-actions github-actions bot mentioned this pull request Mar 13, 2024
Closed
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Mar 26, 2024
@serban300
Define generate_grandpa_key_ownership_proof() (paritytech#2247) (pari…
8c9e59b 
…tytech#2248)
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Mar 27, 2024
@serban300
Define generate_grandpa_key_ownership_proof() (paritytech#2247) (pari…
02efaf2 
…tytech#2248)
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@serban300
Define generate_grandpa_key_ownership_proof() (paritytech#2247) (pari…
5605372 
…tytech#2248)
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@serban300
Define generate_grandpa_key_ownership_proof() (paritytech#2247) (pari…
2ff80d3 
…tytech#2248)
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@serban300
Define generate_grandpa_key_ownership_proof() (paritytech#2247) (pari…
5474ff8 
…tytech#2248)
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@serban300
Define generate_grandpa_key_ownership_proof() (paritytech#2247) (pari…
d2e22ac 
…tytech#2248)
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@serban300
Define generate_grandpa_key_ownership_proof() (paritytech#2247) (pari…
6a4d8d4 
…tytech#2248)
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@serban300
Define generate_grandpa_key_ownership_proof() (paritytech#2247) (pari…
2b7a284 
…tytech#2248)
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@serban300
Define generate_grandpa_key_ownership_proof() (paritytech#2247) (pari…
61921e8 
…tytech#2248)
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@serban300
Define generate_grandpa_key_ownership_proof() (paritytech#2247) (pari…
2a3758c 
…tytech#2248)
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@serban300
Define generate_grandpa_key_ownership_proof() (paritytech#2247) (pari…
c5fb16f 
…tytech#2248)
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@serban300
Define generate_grandpa_key_ownership_proof() (paritytech#2247) (pari…
dbe340a 
…tytech#2248)
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@serban300
Define generate_grandpa_key_ownership_proof() (paritytech#2247) (pari…
f2ca427 
…tytech#2248)
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
@serban300
Define generate_grandpa_key_ownership_proof() (paritytech#2247) (pari…
103c6f8 
…tytech#2248)
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
@serban300
Define generate_grandpa_key_ownership_proof() (paritytech#2247) (pari…
ceec79d 
…tytech#2248)
bkchr pushed a commit that referenced this pull request Apr 10, 2024
@serban300 @bkchr
Define generate_grandpa_key_ownership_proof() (#2247) (#2248)
f6d374b
This was referenced Jun 5, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalkucharczyk michalkucharczyk michalkucharczyk approved these changes

@muharem muharem muharem approved these changes

@seadanda seadanda seadanda approved these changes

@davxy davxy Awaiting requested review from davxy

Assignees

@juangirini juangirini

Labels
R0-silent Changes should not be mentioned in any release notes T11-documentation This PR/Issue is related to documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@juangirini @michalkucharczyk @muharem @davxy @seadanda