Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move developer-hub to sdk-docs #2565

Closed
wants to merge 84 commits into from
Closed

Move developer-hub to sdk-docs #2565

wants to merge 84 commits into from

Conversation

juangirini
Copy link
Contributor

@juangirini juangirini commented Nov 30, 2023

This PR is a continuation of #2102 and part of an initiative started here https://hackmd.io/@romanp/rJ318ZCEp
What has been done:

  • The content under docs/* (with the exception of docs/mermaid) has been moved to docs/contributor/
  • Developer Hub has been renamed to Polkadot SDK Docs, and the crate has been renamed from developer-hub to sdk-docs
  • The content under developer-hub/* has been moved to docs/sdk

kianenigma and others added 30 commits October 31, 2023 09:55
Co-authored-by: Juan Girini <juangirini@gmail.com>
Co-authored-by: bader y <ibnbassem@gmail.com>
Co-authored-by: bader y <ibnbassem@gmail.com>
Co-authored-by: Sebastian Kunert <skunert49@gmail.com>
Co-authored-by: Sebastian Kunert <skunert49@gmail.com>
Co-authored-by: Sebastian Kunert <skunert49@gmail.com>
Co-authored-by: Juan Girini <juangirini@gmail.com>
Co-authored-by: Sebastian Kunert <skunert49@gmail.com>
Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>
Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>
Co-authored-by: Juan Girini <juangirini@gmail.com>
Co-authored-by: Sebastian Kunert <skunert49@gmail.com>
@juangirini juangirini self-assigned this Nov 30, 2023
@juangirini juangirini added the T11-documentation This PR/Issue is related to documentation. label Nov 30, 2023
@juangirini juangirini marked this pull request as ready for review November 30, 2023 10:38
@juangirini juangirini requested a review from a team as a code owner November 30, 2023 10:38
@paritytech-review-bot paritytech-review-bot bot requested a review from a team November 30, 2023 10:39
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4554928

Base automatically changed from kiz-developer-hub to master November 30, 2023 11:15
@juangirini juangirini requested review from a team November 30, 2023 11:15
@juangirini juangirini requested a review from a team November 30, 2023 11:15
Copy link

@rmnprkrl rmnprkrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some "developer_hub" references, not sure if you planned to do it in a separate PR?
I think it might be good to test the build-rustdoc pipeline to check everything works.

@@ -125,7 +125,7 @@ build-rustdoc:
find "$path" -name '*.html' | xargs -I {} -P "$(nproc)" bash -c 'process_file "$@"' _ {}
}
inject_simple_analytics "./crate-docs"
- echo "<meta http-equiv=refresh content=0;url=polkadot_service/index.html>" > ./crate-docs/index.html
- echo "<meta http-equiv=refresh content=0;url=developer_hub/index.html>" > ./crate-docs/index.html
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pipeline references "developer_hub"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that def needs to be updated, @juangirini worth doing a global search / grep of the workspace for developer_hub before merging this if you haven't already

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry guys, there's been some rebase conflicts that broke the PR after changing its base to master, I'll try to fix this PR, otherwise I'll close it and open a new one

@@ -0,0 +1,14 @@
flowchart
parity[paritytech.github.io] --> devhub[developer_hub]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should reference the folder or the crate:

  • "docs/sdk"
  • "sdk-docs"

@@ -0,0 +1,54 @@
<script>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rust docs template references "developer_hub"

//! * [`substrate`], for an overview of what Substrate as the main blockchain framework of Polkadot
//! SDK.
//! * [`frame`], to learn about how to write blockchain applications aka. "App Chains".
//! * Continue with the [`developer_hub`'s "getting started"](crate#getting-started).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

developer_hub

@@ -34,14 +30,21 @@
//! > **F**ramework for **R**untime **A**ggregation of **M**odularized **E**ntities: Substrate's
//! > State Transition Function (Runtime) Framework.
//!
//! ## Documentation
//!
//! See [`polkadot_sdk::frame`](../developer_hub/polkadot_sdk/frame_runtime/index.html).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

developer_hub

@rmnprkrl
Copy link

rmnprkrl commented Dec 1, 2023

regarding the crate name, do you think it is worth to consider "sdk-docs" vs "polkadot-sdk-docs"?

@juangirini
Copy link
Contributor Author

closed in favour of #2598

@juangirini juangirini closed this Dec 4, 2023
@juangirini juangirini deleted the jg/sdk-docs branch December 4, 2023 16:21
juangirini added a commit that referenced this pull request Dec 5, 2023
This PR is a continuation of
#2102 and part of an
initiative started here https://hackmd.io/@romanp/rJ318ZCEp
What has been done:
- The content under `docs/*` (with the exception of `docs/mermaid`) has
been moved to `docs/contributor/`
- Developer Hub has been renamed to Polkadot SDK Docs, and the crate has
been renamed from `developer-hub` to `polkadot-sdk-docs`
- The content under `developer-hub/*` has been moved to `docs/sdk`

---
Original PR #2565, it has
been close due to too many rebase conflicts

---------

Co-authored-by: Serban Iorga <serban@parity.io>
Co-authored-by: Chevdor <chevdor@users.noreply.github.com>
Co-authored-by: Egor_P <egor@parity.io>
Co-authored-by: Bastian Köcher <git@kchr.de>
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
This PR is a continuation of
paritytech#2102 and part of an
initiative started here https://hackmd.io/@romanp/rJ318ZCEp
What has been done:
- The content under `docs/*` (with the exception of `docs/mermaid`) has
been moved to `docs/contributor/`
- Developer Hub has been renamed to Polkadot SDK Docs, and the crate has
been renamed from `developer-hub` to `polkadot-sdk-docs`
- The content under `developer-hub/*` has been moved to `docs/sdk`

---
Original PR paritytech#2565, it has
been close due to too many rebase conflicts

---------

Co-authored-by: Serban Iorga <serban@parity.io>
Co-authored-by: Chevdor <chevdor@users.noreply.github.com>
Co-authored-by: Egor_P <egor@parity.io>
Co-authored-by: Bastian Köcher <git@kchr.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T11-documentation This PR/Issue is related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants