Make crate visible methods of OverlayedChanges public
#2597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParthDesai
changed the title
OverlayedChanges to publicOverlayedChanges public
bkchr
approved these changes
Dec 6, 2023
bkchr
added
T0-node
michalkucharczyk
approved these changes
Dec 6, 2023
ggwpez
approved these changes
Dec 6, 2023
|
@ParthDesai could you please add a |
@bkchr Added. |
ParthDesai
force-pushed
the
make-methods-of-overlayed-changes-public
branch
from
413cc1e
to
81ad969
Compare
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
) # Description - What does this PR do? This PR make some methods of `OverlayedChanges` public which were previously only visible in same crate. - Why are these changes needed? Since, some methods of the `OverlayedChanges` only have crate level visibility, which makes `OverlayedChanges` somewhat unusable outside the crate to create custom implementation of `Externalities`. We make those method public to enable `OverlayedChanges` to remedy this. - How were these changes implemented and what do they affect? Changes are implemented by replacing crate visibility to public visibility of 4 functions. # Checklist - [x] My PR includes a detailed description as outlined in the "Description" section above - [ ] My PR follows the [labeling requirements](CONTRIBUTING.md#Process) of this project (at minimum one label for `T` required) - [ ] I have made corresponding changes to the documentation (if applicable) - [ ] I have added tests that prove my fix is effective or that my feature works (if applicable) --------- Co-authored-by: Bastian Köcher <git@kchr.de>
bkontur
pushed a commit
that referenced
this pull request
Jun 5, 2024
…d at lane (#2597) * compute_per_lane_priority_boost to discuss new approach * clippy * fix incorrect merge
bkontur
pushed a commit
that referenced
this pull request
Jun 7, 2024
…d at lane (#2597) * compute_per_lane_priority_boost to discuss new approach * clippy * fix incorrect merge
bkontur
pushed a commit
that referenced
this pull request
Jun 7, 2024
…d at lane (#2597) * compute_per_lane_priority_boost to discuss new approach * clippy * fix incorrect merge
bkontur
pushed a commit
that referenced
this pull request
Jun 12, 2024
…d at lane (#2597) * compute_per_lane_priority_boost to discuss new approach * clippy * fix incorrect merge
bkontur
pushed a commit
that referenced
this pull request
Jun 13, 2024
…d at lane (#2597) * compute_per_lane_priority_boost to discuss new approach * clippy * fix incorrect merge
bkontur
pushed a commit
that referenced
this pull request
Jun 14, 2024
…d at lane (#2597) * compute_per_lane_priority_boost to discuss new approach * clippy * fix incorrect merge
bkontur
pushed a commit
that referenced
this pull request
Jun 14, 2024
…d at lane (#2597) * compute_per_lane_priority_boost to discuss new approach * clippy * fix incorrect merge
bkontur
pushed a commit
that referenced
this pull request
Jun 14, 2024
…d at lane (#2597) * compute_per_lane_priority_boost to discuss new approach * clippy * fix incorrect merge
bkontur
pushed a commit
that referenced
this pull request
Jun 14, 2024
…d at lane (#2597) * compute_per_lane_priority_boost to discuss new approach * clippy * fix incorrect merge
bkontur
pushed a commit
that referenced
this pull request
Jun 20, 2024
…d at lane (#2597) * compute_per_lane_priority_boost to discuss new approach * clippy * fix incorrect merge
bkontur
pushed a commit
that referenced
this pull request
Jun 20, 2024
…d at lane (#2597) * compute_per_lane_priority_boost to discuss new approach * clippy * fix incorrect merge
bkontur
pushed a commit
that referenced
this pull request
Jun 26, 2024
…d at lane (#2597) * compute_per_lane_priority_boost to discuss new approach * clippy * fix incorrect merge
bkontur
pushed a commit
that referenced
this pull request
Jun 26, 2024
…d at lane (#2597) * compute_per_lane_priority_boost to discuss new approach * clippy * fix incorrect merge
bkontur
pushed a commit
that referenced
this pull request
Jun 28, 2024
…d at lane (#2597) * compute_per_lane_priority_boost to discuss new approach * clippy * fix incorrect merge
bkontur
pushed a commit
that referenced
this pull request
Jul 1, 2024
…d at lane (#2597) * compute_per_lane_priority_boost to discuss new approach * clippy * fix incorrect merge
bkontur
pushed a commit
that referenced
this pull request
Jul 4, 2024
…d at lane (#2597) * compute_per_lane_priority_boost to discuss new approach * clippy * fix incorrect merge
bkontur
pushed a commit
that referenced
this pull request
Jul 16, 2024
…d at lane (#2597) * compute_per_lane_priority_boost to discuss new approach * clippy * fix incorrect merge
bkontur
pushed a commit
that referenced
this pull request
Jul 17, 2024
…d at lane (#2597) * compute_per_lane_priority_boost to discuss new approach * clippy * fix incorrect merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR make some methods of
OverlayedChangespublic which were previously only visible in same crate.Since, some methods of the
OverlayedChangesonly have crate level visibility, which makesOverlayedChangessomewhat unusable outside the crate to create custom implementation ofExternalities. We make those method public to enableOverlayedChangesto remedy this.Changes are implemented by replacing crate visibility to public visibility of 4 functions.
Checklist
Trequired)