Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement only sending one notification at a time as per RFC 56 #2813

Merged
merged 5 commits into from
Jan 2, 2024
Merged

Implement only sending one notification at a time as per RFC 56 #2813

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
49a840b
Only send one notification at a time
tomaka Dec 26, 2023
dc0308f
Add explanation
tomaka Dec 27, 2023
85ed9e6
Add PRdoc
tomaka Dec 27, 2023
919b9e1
Typo and small change
tomaka Dec 27, 2023
38f5e4e
Merge branch 'master' into issue-2812
altonen Jan 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion substrate/client/network/transactions/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,7 +475,11 @@ where
propagated_to.entry(hash).or_default().push(who.to_base58());
}
trace!(target: "sync", "Sending {} transactions to {}", to_send.len(), who);
let _ = self.notification_service.send_sync_notification(who, to_send.encode());
for to_send in to_send {
let _ = self
.notification_service
.send_sync_notification(who, vec![to_send].encode());
Comment on lines +488 to +490
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please at least leave a comment that this is done on purpose.

}
}
}

Expand Down
Loading