Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that the validation code matches the parachain code #3433

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Feb 21, 2024

This introduces a check to ensure that the parachain code matches the validation code stored in the relay chain state. If not, it will print a warning. This should be mainly useful for parachain builders to make sure they have setup everything correctly.

This introduces a check to ensure that the parachain code matches the
validation code stored in the relay chain state. If not, it will print a
warning. This should be mainly useful for parachain builders to make
sure they have setup everything correctly.
@bkchr bkchr requested a review from skunert February 21, 2024 16:20
@bkchr bkchr added R0-silent Changes should not be mentioned in any release notes and removed R0-silent Changes should not be mentioned in any release notes labels Feb 21, 2024
},
};

match state_validation_code_hash {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be turned into a let Some(state) = state_validation_code_hash else { ... }.

@acatangiu acatangiu added the R0-silent Changes should not be mentioned in any release notes label Feb 22, 2024
@acatangiu acatangiu added this pull request to the merge queue Feb 22, 2024
Merged via the queue into master with commit 9bf1a5e Feb 22, 2024
137 of 142 checks passed
@acatangiu acatangiu deleted the bkchr-check-validation-code branch February 22, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants