collation-generation: Avoid using para_backing_state if runtime is ancient
#4070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandreim
added
R0-silent
bkchr
approved these changes
Apr 10, 2024
|
Asked for a burn-in to confirm the fix. We'll have to do a hotfix release once this is merged/backported. |
eskimor
approved these changes
Apr 10, 2024
|
The burn-in on Polkadot AssetHub collators confirms that this is fixing the issue of collators not producing blocks. |
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
bkchr
approved these changes
Apr 11, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4067
Also add an early bail out for look ahead collator such that we don't waste time if a CollatorFn is not set.
TODO: