Moves runtime macro out of experimental flag #4249
Conversation
There was a problem hiding this comment.
Generally not sure if just because it was deployed on one network, it should be taken out of the experimental flag? Given this argument, we would have never needed to add it there in the first place, because no downstream user had even the time to try this out.
Co-authored-by: Bastian Köcher <git@kchr.de>
Yeah, makes sense. @ggwpez had suggested to put in under the experimental flag to make sure that the metadata is not impacted after the change. I felt that this has been validated now but happy to wait in case you feel something else is needed first. |
There was a problem hiding this comment.
Which test networks are using this now?
I have less of a strong opinion on letting it remain experimental, probably would opt for the safer option of letting it be there for now.
Instead, I would put the focus on making sure this is used as much as possible within our codebase/templates.
Currently on westend.
Yeah, my hope was to add it in all test runtimes, but the experimental flag makes it difficult. |
* master: (93 commits) Fix broken windows build (#4636) Beefy client generic on aduthority Id (#1816) pallet-staking: Put tests behind `cfg(debug_assertions)` (#4620) Broker new price adapter (#4521) Change `XcmDryRunApi::dry_run_extrinsic` to take a call instead (#4621) Update README.md (#4623) Publish `chain-spec-builder` (#4518) Add omni bencher & chain-spec-builder bins to release (#4557) Moves runtime macro out of experimental flag (#4249) Filter workspace dependencies in the templates (#4599) parachain-inherent: Make `para_id` more prominent (#4555) Add metric to measure the time it takes to gather enough assignments (#4587) Improve On_demand_assigner events (#4339) Conditional `required` checks (#4544) [CI] Deny adding git deps (#4572) [subsytem-bench] Remove redundant banchmark_name param (#4540) Add availability-recovery from systematic chunks (#1644) Remove workspace lints from templates (#4598) `sc-chain-spec`: deprecated code removed (#4410) [subsystem-benchmarks] Add statement-distribution benchmarks (#3863) ...
Step in paritytech#3688 Now that the `runtime` macro (Construct Runtime V2) has been successfully deployed on Westend, this PR moves it out of the experimental feature flag and makes it generally available for runtime devs. --------- Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Step in paritytech#3688 Now that the `runtime` macro (Construct Runtime V2) has been successfully deployed on Westend, this PR moves it out of the experimental feature flag and makes it generally available for runtime devs. --------- Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Step in #3688
Now that the
runtimemacro (Construct Runtime V2) has been successfully deployed on Westend, this PR moves it out of the experimental feature flag and makes it generally available for runtime devs.