Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pallet::getter usage from the democracy pallet #4472

Merged
merged 6 commits into from
May 16, 2024
Merged

Remove pallet::getter usage from the democracy pallet #4472

merged 6 commits into from
May 16, 2024

Conversation

PolkadotDom
Copy link
Contributor

@PolkadotDom PolkadotDom commented May 15, 2024 •
edited by mordamax
Loading

As per #3326, removes usage of the pallet::getter macro from the democracy pallet. The syntax StorageItem::<T, I>::get() should be used instead.

cc @muraca

Polkadot address: 1L66uQMKFnXKSZx9pCD5o56GvvP1i2Qns7CaS2AaKp9mnwc

@PolkadotDom PolkadotDom requested a review from a team as a code owner May 15, 2024 15:05
@bkchr bkchr added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label May 16, 2024
@bkchr bkchr enabled auto-merge May 16, 2024 13:53
@bkchr bkchr added this pull request to the merge queue May 16, 2024
@ggwpez
Copy link
Member

ggwpez commented May 16, 2024

/tip small

@substrate-tip-bot substrate-tip-bot
Copy link

@PolkadotDom Contributor did not properly post their account address.

Make sure the pull request description (or user bio) has: "{network} address: {address}".

@mordamax
Copy link
Contributor

@PolkadotDom it should be {kusama|polkadot|localtest} address: <SS58 Address> either in the bio or here in issue, fyi
https://github.com/paritytech/substrate-tip-bot/?tab=readme-ov-file#pull-request-body

@mordamax
Copy link
Contributor

/tip small

@substrate-tip-bot substrate-tip-bot
Copy link

@mordamax A referendum for a small (20 DOT) tip was successfully submitted for @PolkadotDom (1L66uQMKFnXKSZx9pCD5o56GvvP1i2Qns7CaS2AaKp9mnwc on polkadot).

Referendum number: 778.
tip

@PolkadotDom
Copy link
Contributor Author

@PolkadotDom it should be {kusama|polkadot|localtest} address: <SS58 Address> either in the bio or here in issue, fyi https://github.com/paritytech/substrate-tip-bot/?tab=readme-ov-file#pull-request-body

Ah okay, thank you. I believe I've set it correctly now 👍

Merged via the queue into paritytech:master with commit 04f88f5 May 16, 2024
152 of 155 checks passed
@PolkadotDom PolkadotDom deleted the dom/remove-getters-democracy-pallet branch May 16, 2024 15:14
@muraca muraca mentioned this pull request May 17, 2024
Open
63 tasks
hitchhooker pushed a commit to ibp-network/polkadot-sdk that referenced this pull request Jun 5, 2024
@PolkadotDom @hitchhooker
Remove pallet::getter usage from the democracy pallet (paritytech#4472)
1e38083 
As per paritytech#3326, removes usage of the pallet::getter macro from the
democracy pallet. The syntax `StorageItem::<T, I>::get()` should be used
instead.

cc @muraca
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
@PolkadotDom @TarekkMA
Remove pallet::getter usage from the democracy pallet (paritytech#4472)
61f1be3 
As per paritytech#3326, removes usage of the pallet::getter macro from the
democracy pallet. The syntax `StorageItem::<T, I>::get()` should be used
instead.

cc @muraca
This was referenced Aug 21, 2024
Open
Open
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkchr bkchr bkchr approved these changes

@ggwpez ggwpez ggwpez approved these changes

Assignees
No one assigned
Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PolkadotDom @ggwpez @mordamax @bkchr