Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nomination-pools] Backport of #4503. Fix pools with extra consumer ref to be destroyed. #4524

Merged
merged 1 commit into from
May 20, 2024

Conversation

Ank4n
Copy link
Contributor

@Ank4n Ank4n commented May 20, 2024

Backporting #4503 to polkadot-sdk 1.7.0 release. Should bump pallet-nomination-pools from 26.0.0 to 26.0.1.

…ce on the pool account (#4503)

addresses #4440 (will
close once we have this in prod runtimes).
related: #2037.

An extra consumer reference is preventing pools to be destroyed. When a
pool is ready to be destroyed, we
can safely clear the consumer references if any. Notably, I only check
for one extra consumer reference since that is a known bug. Anything
more indicates possibly another issue and we probably don't want to
silently absorb those errors as well.

After this change, pools with extra consumer reference should be able to
destroy normally.
@Ank4n Ank4n added the I2-bug The node fails to follow expected behavior. label May 20, 2024
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 2/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6246399

@Ank4n Ank4n added the A3-backport Pull request is already reviewed well in another branch. label May 20, 2024
@Ank4n Ank4n merged commit 6d1bef4 into release-crates-io-v1.7.0 May 20, 2024
27 of 79 checks passed
@Ank4n Ank4n deleted the ankan/backport-destroy-pool-170 branch May 20, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A3-backport Pull request is already reviewed well in another branch. I2-bug The node fails to follow expected behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants