Reinitialize should allow to override existing config in collationGeneration #4833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eneration subsystem
IMO sounds better to me and reflects more what the name says. |
|
WIll change it to that then! thank you @bkchr |
girazoki
changed the title
|
Changed @bkchr |
bkchr
approved these changes
Jun 21, 2024
bkchr
added
R0-silent
|
@girazoki can you write a prdoc? |
sure |
skunert
approved these changes
Jun 21, 2024
prdoc/pr_4833.prdoc
Outdated
|
|
||
| crates: | ||
| - name: polkadot-node-collation-generation | ||
| bump: none |
There was a problem hiding this comment.
Should be patch as the behaviour changes.
sandreim
approved these changes
Jun 21, 2024
Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com>
bkchr
reviewed
Jun 23, 2024
Merged
via the queue into
paritytech:master
with commit Jun 23, 2024
f8feebc
142 of 158 checks passed
TarekkMA
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Aug 2, 2024
…eration (paritytech#4833) Currently the `Initialize` and `Reinitialize` messages in the collationGeneration subsystem fail if: - `Initialize` if there exists already another configuration and - `Reinitialize` if another configuration does not exist I propose to instead change the behaviour of `Reinitialize` to always set the config regardless of whether one exists or not. --------- Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com>
This was referenced Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the
InitializeandReinitializemessages in the collationGeneration subsystem fail if:Initializeif there exists already another configuration andReinitializeif another configuration does not existI propose to instead change the behaviour of
Reinitializeto always set the config regardless of whether one exists or not.