Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Para Inherent: filter v2 candidate descriptors #5362

Merged
merged 14 commits into from
Aug 22, 2024
Merged

Para Inherent: filter v2 candidate descriptors #5362

merged 14 commits into from
Aug 22, 2024

Conversation

sandreim
Copy link
Contributor

@sandreim sandreim commented Aug 14, 2024 •
edited
Loading

On top of #5322

This is an additional check to prevent nodes from passing the v2 candidate descriptors in the runtime until it is enabled via the node feature.

TODO:

  • PRDoc

@sandreim
Filter v2 candidate descriptors
5e4dac2 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
fix
f12ca7a 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
fix prospective parachains tests
13734de 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7015977

@sandreim
fix fix
effb1cc 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
fmt
3f75cba 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
fix comment
75a47bb 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
another one
12ed853 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
fix build
f2c0882 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
alindima
alindima reviewed Aug 15, 2024
View reviewed changes
Copy link
Contributor

@alindima alindima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

polkadot/primitives/src/vstaging/mod.rs Show resolved Hide resolved
polkadot/runtime/parachains/src/paras_inherent/mod.rs Show resolved Hide resolved
polkadot/runtime/parachains/src/paras_inherent/tests.rs Outdated Show resolved Hide resolved
@sandreim
.
768e034 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
improve test and add comment
4bf0706 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
add log
0c83201 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim sandreim self-assigned this Aug 20, 2024
@sandreim sandreim mentioned this pull request Aug 20, 2024
Open
6 tasks
@alindima
Copy link
Contributor

I think you can merge this, since it's on the other branch also and it's hard to review without the context of the primitives PR.
Others can review it on that PR

@sandreim sandreim merged commit 1db5eb0 into sandreim/rfc103-primitives Aug 22, 2024
181 of 189 checks passed
@sandreim sandreim deleted the sandreim/filter_v2_descriptors branch August 22, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alindima alindima alindima approved these changes

Assignees

@sandreim sandreim

Labels
None yet
Projects
parachains team board
Status: Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sandreim @paritytech-cicd-pr @alindima