Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump parity-common #5673

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Bump parity-common #5673

wants to merge 7 commits into from

Conversation

pgherveou
Copy link
Contributor

@pgherveou pgherveou commented Sep 11, 2024

@pgherveou pgherveou added the dependencies Pull requests that update a dependency file label Sep 11, 2024
@pgherveou pgherveou changed the title Bumping parity-common Bump parity-common Sep 11, 2024
@ordian
Copy link
Member

ordian commented Sep 11, 2024

$ cargo tree -i -p primitive-types@0.12.1 | less

primitive-types v0.12.1
└── sp-runtime-interface v17.0.0 (https://github.com/paritytech/polkadot-sdk#82912acb)
    └── sp-crypto-ec-utils v0.4.1 (https://github.com/paritytech/polkadot-sdk#82912acb)
        ├── sp-ark-bls12-381 v0.4.2 (https://github.com/paritytech/arkworks-substrate#caa2eed7)
        │   └── bandersnatch_vrfs v0.0.4 (https://github.com/w3f/ring-vrf?rev=0fef826#0fef8266)
        │       └── sp-core v28.0.0 (/Users/andronik/code/polkadot-sdk/substrate/primitives/core)

Not sure what is the right sequence of updating these deps anymore
This looks like a circular dependency to me 😬 https://github.com/paritytech/arkworks-substrate/blob/caa2eed74beb885dd07c7db5f916f2281dad818f/Cargo.toml#L32

@pgherveou pgherveou marked this pull request as ready for review September 12, 2024 11:37
@pgherveou pgherveou added dependencies Pull requests that update a dependency file D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. and removed dependencies Pull requests that update a dependency file labels Sep 12, 2024
@pgherveou pgherveou requested a review from a team as a code owner September 12, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants