Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

[CI] Add criticality of release to release notes #1259

Merged
merged 12 commits into from
Jun 17, 2020
Merged

Conversation

s3krit
Copy link
Contributor

@s3krit s3krit commented Jun 12, 2020

  • Enforces presence of C-labels to designate the importance of a release
  • Iterates over them on a release, takes the highest present and includes it in the release notes
  • Lists the change(s) that caused the release to be that priority

Devops ticket here: https://github.com/paritytech/devops/issues/569

@s3krit s3krit added M1-ci B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Jun 12, 2020
@coriolinus
Copy link
Contributor

If we mandate a C label, then I'd suggest a C0-irrelevant or similar label for PRs which don't affect end-users at all, such as this one, or #1257.

@s3krit
Copy link
Contributor Author

s3krit commented Jun 15, 2020

If we mandate a C label, then I'd suggest a C0-irrelevant or similar label for PRs which don't affect end-users at all, such as this one, or #1257.

Think of the label as something that changes the importance of the user updating in a timely manner - the default importance for the user updating is Low. The importance of a release should never be 'irrelevant' (else why make a release at all). We could also have it so that PRs are by default labelled as low importance, but having it as a manual step causes the author of the PR to think a little about the importance of their PR.

@gavofyork gavofyork removed the M1-ci label Jun 15, 2020
@gavofyork
Copy link
Member

Think of the label as something that changes the importance of the user updating in a timely manner - the default importance for the user updating is Low. The importance of a release should never be 'irrelevant' (else why make a release at all). We could also have it so that PRs are by default labelled as low importance, but having it as a manual step causes the author of the PR to think a little about the importance of their PR.

agree on all points.

@s3krit s3krit marked this pull request as ready for review June 16, 2020 16:43
@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Jun 16, 2020
@s3krit
Copy link
Contributor Author

s3krit commented Jun 16, 2020

There can be some confusing bash in here due to the use of associative arrays, but I'm happy to walk any reviewers through it. In the very near future I hope to re-engineer this script in a more suitable language.

@s3krit s3krit changed the title [CI][WIP] Add criticality of release to release notes [CI] Add criticality of release to release notes Jun 16, 2020
Copy link
Contributor

@gabreal gabreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -157,9 +157,7 @@ build-wasm-release:
<<: *compiler_info
# Note: We likely only want to do this for tagged releases, hence the 'only:'
only:
# FIXME remove when ready to merge
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget

@s3krit s3krit marked this pull request as draft June 17, 2020 09:01
@s3krit s3krit marked this pull request as ready for review June 17, 2020 11:29
@s3krit s3krit merged commit fdc278a into master Jun 17, 2020
@s3krit s3krit deleted the mp-criticality-labels branch June 17, 2020 12:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants