Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Companion for #6610 (Balances Weight Trait) #1425

Merged
merged 6 commits into from
Jul 30, 2020

Conversation

shawntabrizi
Copy link
Member

@shawntabrizi shawntabrizi commented Jul 17, 2020

This is a companion for: paritytech/substrate#6610

This updates to new "extra" param in the benchmarking pipeline, and adds weights to each of the 3 production runtimes for the balances pallet.

Weight Comparison

Before After
Transfer 70_000_000 65_949_000
Transfer Keep Alive 50_000_000 46_665_000
Set Balance 35_000_000 33_424_000
Force Transfer 70_000_000 65_343_000

@shawntabrizi shawntabrizi added the A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. label Jul 29, 2020
Copy link
Contributor

@gui1117 gui1117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are good to me,

But how is update of weight integrated into CI ? will it be manual for each runtime release ?

@shawntabrizi
Copy link
Member Author

shawntabrizi commented Jul 30, 2020

@thiolliere CI is not integrated yet. Will need to work on that too at some point.... :|

But need to migrate things first I think

@shawntabrizi shawntabrizi added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Jul 30, 2020
@shawntabrizi
Copy link
Member Author

bot merge

@ghost
Copy link

ghost commented Jul 30, 2020

Missing process info; check that the PR belongs to a project column.

@shawntabrizi
Copy link
Member Author

bot merge

@ghost
Copy link

ghost commented Jul 30, 2020

Missing process info; check that the PR belongs to a project column.

@shawntabrizi shawntabrizi added B2-runtimenoteworthy and removed B0-silent Changes should not be mentioned in any release notes labels Jul 30, 2020
@shawntabrizi shawntabrizi merged commit 7cffb42 into master Jul 30, 2020
@shawntabrizi shawntabrizi deleted the shawntabrizi-balance-weight-trait branch July 30, 2020 16:43
ordian added a commit that referenced this pull request Jul 31, 2020
* master:
  Candidate Validation Subsystem (#1432)
  reduce slash defer durations (#1504)
  Implement the Runtime API subsystem (#1494)
  Companion for #6610 (Balances Weight Trait) (#1425)
  [CI] Publish draft release redux (#1493)
  Update README docs related to local build (#1479)
  Add a default trie-memory-tracker feature to the cli (#1502)
  Companion PR for `Add a `DefaultQueue` type alias to remove the need to use `sp_api::TransactionFor`` (#1499)
  Fix bitfield signing (#1466)
  Update Substrate, bump versions, clean up sort (#1496)
  Bump Substrate
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants