This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Use SpawnNamed instead of Spawn in Overseer #1430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montekki
added
A0-please_review
rphmeier
reviewed
Jul 17, 2020
rphmeier
approved these changes
Jul 17, 2020
ordian
reviewed
Jul 17, 2020
Comment on lines
+173
to
+177
| async fn spawn(&mut self, name: &'static str, s: Pin<Box<dyn Future<Output = ()> + Send>>) | ||
| -> SubsystemResult<()> | ||
| { | ||
| self.spawn.spawn(name, s); | ||
| Ok(()) |
There was a problem hiding this comment.
looks like the result or spawn is ignored here compared to the previous revision or am I missing something?
i.e. should it have a question mark after spawn?
this is test code, maybe it doesn't matter, just curious
| @@ -101,7 +101,12 @@ impl From<std::convert::Infallible> for SubsystemError { | |||
| /// An asynchronous subsystem task.. | |||
| /// | |||
| /// In essence it's just a newtype wrapping a `BoxFuture`. | |||
There was a problem hiding this comment.
this docstring is now a bit outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1378