This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
guide: validation data refactoring #1576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepyakin
added
B0-silent
pepyakin
reviewed
Aug 13, 2020
roadmap/implementers-guide/src/runtime-api/persisted-validation-data.md
Outdated
Show resolved
Hide resolved
| @@ -35,9 +35,6 @@ fn update_configuration(f: impl FnOnce(&mut HostConfiguration)) { | |||
| *pending = Some(x); | |||
| }) | |||
| } | |||
|
|
|||
| /// Get the GlobalValidationData, assuming the context is the parent block. | |||
| fn global_validation_data() -> GlobalValidationData; | |||
There was a problem hiding this comment.
local_validation_data was queried from paras.md. global_validation_data was declared here, in configuration.md.
In the presented changes, persisted_validation_data is queried from paras.md but where do I query full_validation_data to implement the runtime API call with the same name?
There was a problem hiding this comment.
The runtime API will need to draw this information out from many different modules. It wasn't obvious where its home should be.
There was a problem hiding this comment.
yeah I actually was triggered by that: it wasn't for me where would be the home and then I thought that the chances are it might be not obvious for the implementer either.
but that's fine, we can figure out this later
pepyakin
reviewed
Aug 13, 2020
|
Apart from the above, there is also collation-generation.md:
|
pepyakin
reviewed
Aug 13, 2020
drahnr
reviewed
Aug 13, 2020
Co-authored-by: Bernhard Schuster <bernhard@ahoi.io>
pepyakin
approved these changes
Aug 13, 2020
coriolinus
approved these changes
Aug 13, 2020
|
I like transient a lot better. I was hoping someone would bikeshed this! |
…olkadot into rh-validation-data-refactor
|
bot merge |
|
Waiting for commit status. |
ghost
merged commit
ordian
added a commit
that referenced
this pull request
Aug 14, 2020
* master: Make parachain validation wasm executor functional (#1574) Use async test helper to simplify node testing (#1578) guide: validation data refactoring (#1576) Remove v0 parachains runtime (#1501) [CI] Add github token to generate-release-text (#1581) Allow using any polkadot client instead of enum Client (#1575) service/src/lib: Update authority discovery construction (#1563) Update .editorconfig to what we have in practice (#1545) Companion PR for substrate #6672 (#1560) pre-redenomination tockenSymbol change (#1561)
ordian
added a commit
that referenced
this pull request
Aug 17, 2020
…n-race-condition * master: Companion PR for #6862 (#1564) implement collation generation subsystem (#1557) Add spawn_blocking to SubsystemContext (#1570) Companion PR for #6846 (#1568) overseer: add a test to ensure all subsystem receive msgs (#1590) Implementer's Guide: Flesh out more details for upward messages (#1556) Make parachain validation wasm executor functional (#1574) Use async test helper to simplify node testing (#1578) guide: validation data refactoring (#1576) Remove v0 parachains runtime (#1501) [CI] Add github token to generate-release-text (#1581) Allow using any polkadot client instead of enum Client (#1575) service/src/lib: Update authority discovery construction (#1563)
ordian
added a commit
that referenced
this pull request
Aug 17, 2020
* master: overseer: fix build (#1596) Companion PR for #6862 (#1564) implement collation generation subsystem (#1557) Add spawn_blocking to SubsystemContext (#1570) Companion PR for #6846 (#1568) overseer: add a test to ensure all subsystem receive msgs (#1590) Implementer's Guide: Flesh out more details for upward messages (#1556) Make parachain validation wasm executor functional (#1574) Use async test helper to simplify node testing (#1578) guide: validation data refactoring (#1576) Remove v0 parachains runtime (#1501) [CI] Add github token to generate-release-text (#1581) Allow using any polkadot client instead of enum Client (#1575) service/src/lib: Update authority discovery construction (#1563) Update .editorconfig to what we have in practice (#1545) Companion PR for substrate #6672 (#1560) pre-redenomination tockenSymbol change (#1561)
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #1539
implementation following in another PR