This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Benchmark Slots and Auction #2181
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlc
reviewed
Dec 30, 2020
| @@ -1751,3 +1751,48 @@ mod tests { | |||
| }); | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(feature = "runtime-benchmarks")] | |||
There was a problem hiding this comment.
this don't deserve a new file? this file is already > 1500 lines...
|
Related to #1512 also? |
gavofyork
reviewed
Jan 18, 2021
| @@ -530,8 +532,10 @@ decl_module! { | |||
| // Should have already begun. Remove the on-boarding entry and register the | |||
| // parachain for its immediate start. | |||
| <Onboarding<T>>::remove(¶_id); | |||
| let _ = T::Parachains:: | |||
| // TODO: Probably best to make sure this doesn't fail or handle fail conditions. | |||
gavofyork
added
A3-in_progress
|
replaced elsewhere |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in progress