Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

companion for substrate/pull/8044 #2765

Merged
7 commits merged into from
Apr 23, 2021
Merged

companion for substrate/pull/8044 #2765

7 commits merged into from
Apr 23, 2021

Conversation

kianenigma
Copy link
Contributor

@kianenigma kianenigma commented Mar 30, 2021 •
edited
Loading

Companion to paritytech/substrate#8044

  • Not yet tested for migrations.

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Mar 30, 2021
@kianenigma kianenigma changed the title Kiz companion 8044 companion for substrate/pull/8044 Mar 30, 2021
@kianenigma kianenigma added B7-runtimenoteworthy C1-low PR touches the given topic and has a low impact on builders. E0-runtime_migration PR introduces code that might require downstream chains to run a runtime upgrade. labels Mar 30, 2021
@kianenigma kianenigma mentioned this pull request Mar 30, 2021
Merged
@kianenigma kianenigma added D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. and removed E0-runtime_migration PR introduces code that might require downstream chains to run a runtime upgrade. labels Apr 15, 2021
@gui1117
Copy link
Contributor

gui1117 commented Apr 15, 2021

note: renaming the pallet makes the stored version outdated, the version is stored using the name of the pallet, thus we probably want to clean the version stored at the old name, and we have to be careful the renamed pallet is considered at its latest version (because no version is stored at its new name).

gui1117
gui1117 approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@gui1117 gui1117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

We need to clean the old version stored at twox128(b"ElectionsPhragmen")++twox128(PALLET_VERSION_STORAGE_KEY_POSTFIX).

And be sure we that we don't use the version in the next PRs until next upgrade.

@kianenigma kianenigma mentioned this pull request Apr 23, 2021
Closed
@ghost
Copy link

ghost commented Apr 23, 2021

Waiting for commit status.

@ghost ghost merged commit 24549ae into master Apr 23, 2021
@ghost ghost deleted the kiz-companion-8044 branch April 23, 2021 07:54
@AurevoirXavier AurevoirXavier mentioned this pull request May 11, 2021
Merged
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gui1117 gui1117 gui1117 approved these changes

@shawntabrizi shawntabrizi Awaiting requested review from shawntabrizi

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kianenigma @gui1117