Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Flood protection for large statements. #2984

Merged
merged 4 commits into from
May 6, 2021
Merged

Flood protection for large statements. #2984

merged 4 commits into from
May 6, 2021

Conversation

eskimor
Copy link
Member

@eskimor eskimor commented May 6, 2021 •
edited
Loading

That's the simplest solution I could come up with. Problem is described in code. Sanity checking, whether my logic is sound, is greatly appreciated.

@eskimor eskimor added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels May 6, 2021
ordian
ordian approved these changes May 6, 2021
View reviewed changes
Copy link
Member

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

20 large statement per peer per relay parent seems like a reasonable workaround for now

@eskimor eskimor merged commit 46e3986 into master May 6, 2021
@eskimor eskimor deleted the rk-statements-flood branch May 6, 2021 18:41
@eskimor eskimor restored the rk-statements-flood branch June 14, 2021 14:30
@eskimor eskimor deleted the rk-statements-flood branch June 14, 2021 14:34
@eskimor eskimor mentioned this pull request Nov 11, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ordian ordian ordian approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eskimor @ordian