Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

revert +1 change to be on the safer side #3972

Merged
1 commit merged into from
Sep 29, 2021
Merged

revert +1 change to be on the safer side #3972

1 commit merged into from
Sep 29, 2021

Conversation

ordian
Copy link
Member

@ordian ordian commented Sep 29, 2021

There was a concern raised after #3954 (comment) that in

polkadot/node/subsystem-util/src/rolling_session_window.rs

Line 180 in 71a721e

match load_all_sessions(ctx, block_hash, window_start, session_index).await {
it would fail on startup because runtime doesn't store enough sessions. But that's actually not true, runtime stores dispute_period + 1 session infos:

polkadot/runtime/parachains/src/session_info.rs

Line 108 in 71a721e

let new_earliest_stored_session = new_session_index.saturating_sub(dispute_period);

Anyway, we revert it to be on the safer side.

@ordian ordian added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Sep 29, 2021
@rphmeier
Copy link
Contributor

bot merge

@ghost
Copy link

ghost commented Sep 29, 2021

Waiting for commit status.

@ghost ghost merged commit 1f0d9cc into master Sep 29, 2021
@ghost ghost deleted the ao-revert-plus-one-change branch September 29, 2021 19:24
ordian added a commit that referenced this pull request Sep 30, 2021
@ordian
Merge branch 'master' into ladi-logging-disputes
cac79f1 
* master: (52 commits)
  Companion for substrate PR#9890 (#3961)
  Bump version, tx_version and spec_version in prep for v0.9.11 (#3970)
  Fix master compilation (#3977)
  Make most XCM APIs accept an Into<MultiLocation> where MultiLocation is accepted (#3627)
  fix disputes tests (#3974)
  Drop availability only for candidates that lose disputes (#3973)
  revert +1 change to be on the safer side (#3972)
  paras_inherent: reject only candidates with concluded disputes (#3969)
  feat: measured oneshots (#3902)
  remove `AllSubsystems` and `AllSubsystemsGen` types (#3874)
  Companion for Substrate#9867 (#3938)
  Substrate Companion for #9552 (#3834)
  CI: run disputes tests (#3962)
  Bump parity-scale-codec from 2.3.0 to 2.3.1 (#3959)
  approval-voting: populate session cache in advance (#3954)
  Bump libc from 0.2.102 to 0.2.103 (#3950)
  fix master (#3955)
  Docker files chore (#3880)
  Bump nix from 0.19.1 to 0.20.0 (#3587)
  remove connected disconnected state, 3rd attempt (#3898)
  ...
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rphmeier rphmeier rphmeier approved these changes

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ordian @rphmeier