This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Remove incorrect proof about Jemalloc #3982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The truth is that Jemalloc is not always the default allocator. This is only true for the polkadot binary.
bkchr
added
A0-please_review
ordian
approved these changes
Oct 1, 2021
node/overseer/src/lib.rs
Outdated
| Err(_) => { | ||
| tracing::debug!( | ||
| target: LOG_TARGET, | ||
| "Jemalloc not set as allocator, so memory allocations will not be tracked", |
There was a problem hiding this comment.
maybe worth making the log message generic (as in #3893) if we're to add support for other allocators in the future, but your call :P
There was a problem hiding this comment.
What you mean by making it generic?
There was a problem hiding this comment.
Ahh. I mean currently it is only supported for Jemalloc and will probably not change in the near future?
|
bot merge |
|
Waiting for commit status. |
drahnr
approved these changes
Oct 1, 2021
|
Merge failed: "Pull Request is not mergeable" |
ordian
added a commit
to Lldenaurois/polkadot
that referenced
this pull request
Oct 2, 2021
* master: preserve finalized block in active leaves (paritytech#3997) some tweaks to rococo-local (paritytech#3996) always broadcast tranche 0 assignments and add a delay before approval (paritytech#3904) Tidy up XCM errors in preparation for v2. (paritytech#3988) add disputes call to Rococo (paritytech#3993) Fix an off-by-one: revert rather than revert-to (paritytech#3991) add logs to relay chain selection (paritytech#3990) av-store: clean up StoreAvailableData message (paritytech#3984) add polkadot-simnet runner (paritytech#3985) Remove incorrect proof about Jemalloc (paritytech#3982) add new rococo chainspec (paritytech#3976) bump async-std's version to remove conflict for substrate (paritytech#3981) gossip-support: set last_session_index earlier (paritytech#3978)
ordian
added a commit
that referenced
this pull request
Oct 3, 2021
* master: (72 commits) change genesis authority set for wococo-local, revert rococo-local (#3998) ignore irrelevant approvals in logs (#3859) avoid expect, on free availability core (#3994) preserve finalized block in active leaves (#3997) some tweaks to rococo-local (#3996) always broadcast tranche 0 assignments and add a delay before approval (#3904) Tidy up XCM errors in preparation for v2. (#3988) add disputes call to Rococo (#3993) Fix an off-by-one: revert rather than revert-to (#3991) add logs to relay chain selection (#3990) av-store: clean up StoreAvailableData message (#3984) add polkadot-simnet runner (#3985) Remove incorrect proof about Jemalloc (#3982) add new rococo chainspec (#3976) bump async-std's version to remove conflict for substrate (#3981) gossip-support: set last_session_index earlier (#3978) Companion for substrate PR#9890 (#3961) Bump version, tx_version and spec_version in prep for v0.9.11 (#3970) Fix master compilation (#3977) Make most XCM APIs accept an Into<MultiLocation> where MultiLocation is accepted (#3627) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The truth is that Jemalloc is not always the default allocator. This is
only true for the polkadot binary.