This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Rename Statemint where appropriate #4087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KiChjang
added
A0-please_review
apopiak
reviewed
Oct 15, 2021
runtime/rococo/src/lib.rs
Outdated
| @@ -644,15 +644,15 @@ parameter_types! { | |||
| pub const RococoForTick: (MultiAssetFilter, MultiLocation) = (Rococo::get(), Parachain(100).into()); | |||
| pub const RococoForTrick: (MultiAssetFilter, MultiLocation) = (Rococo::get(), Parachain(110).into()); | |||
| pub const RococoForTrack: (MultiAssetFilter, MultiLocation) = (Rococo::get(), Parachain(120).into()); | |||
| pub const RococoForStatemint: (MultiAssetFilter, MultiLocation) = (Rococo::get(), Parachain(1001).into()); | |||
| pub const RococoForRockmint: (MultiAssetFilter, MultiLocation) = (Rococo::get(), Parachain(1001).into()); | |||
There was a problem hiding this comment.
Suggested change
| pub const RococoForRockmint: (MultiAssetFilter, MultiLocation) = (Rococo::get(), Parachain(1001).into()); | |
| pub const RococoForRockmine: (MultiAssetFilter, MultiLocation) = (Rococo::get(), Parachain(1001).into()); |
Your petition to name it Rockmine was heard :-D
Also: shouldn't it be Parachain 1000? @shawntabrizi do you remember why it was set to 1001 here?
apopiak
reviewed
Oct 15, 2021
apopiak
approved these changes
Oct 15, 2021
Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>
|
Thanks! |
ordian
added a commit
that referenced
this pull request
Oct 27, 2021
* master: (73 commits) Fix XCM Teleport Benchmark (#4146) Allow Queries and Subscriptions (#4150) Fix weights on hard-coded XCM fragments (#4144) Bump spec versions (#4142) Bump libc from 0.2.104 to 0.2.105 (#4141) Enable bags-list pallet in polkadot (#4080) Move artifacts states into memory in PVF validation host (#3907) Introduce new Runtime API endpoint for fetching the validation data (#3728) export xcm_pallet config (#4116) Apply cargo fmt (#4122) remove logging from the check-dependent-* job (#4120) Remove stale migrations (#4107) Bump structopt from 0.3.23 to 0.3.25 (#4098) remove hardcoded pipeline scripts tag (#4109) Bump libc from 0.2.103 to 0.2.104 (#4099) some spelling fixes (#4088) polkadot: remove call filters on registrar pallets (#4093) Fix typos in docs (#4092) Rename Statemint where appropriate (#4087) bump substrate (#4091) ...
emostov
pushed a commit
that referenced
this pull request
Nov 1, 2021
* Rename Statemint where appropriate * Rename to Rockmine Co-authored-by: Alexander Popiak <alexander.popiak@parity.io> Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During @shawntabrizi's Sub0 talk, it was found out that there are places in the code where we mention Statemint, but actually meant Statemine or Rockmint. Updated the references so that they use the proper name for their respective asset reserve chains.