Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

XCM V3 (Non-controversial Subset) #6564

Closed
wants to merge 12 commits into from

Conversation

shawntabrizi
Copy link
Member

@shawntabrizi shawntabrizi commented Jan 16, 2023

To reduce the diff of: #4097

This extracts trivial changes, and allows reviewers to focus on the more important details of the PR.

cumulus companion: paritytech/cumulus#2097

@shawntabrizi shawntabrizi added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Jan 16, 2023
@paritytech-ci paritytech-ci requested review from a team January 16, 2023 21:02
@paritytech-ci paritytech-ci requested review from a team January 17, 2023 02:50
Comment on lines +182 to +187
if <Self as Store>::DownwardMessageQueues::decode_len(para).unwrap_or(0) >
MAX_MESSAGE_QUEUE_SIZE
{
return Err(QueueDownwardMessageError::ExceedsMaxMessageSize)
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might be the only logic change, but seems pretty uncontroversial

@bkchr
Copy link
Member

bkchr commented Jan 17, 2023

The relevant pr was already merged, so this isn't needed anymore

@bkchr bkchr closed this Jan 17, 2023
@bkchr bkchr deleted the shawntabrizi-xcm-v3-subset branch January 17, 2023 08:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants