Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

polkadot companion #12608 (Pools claim permissions) #6753

Merged
merged 9 commits into from
Feb 22, 2023
Merged

polkadot companion #12608 (Pools claim permissions) #6753

merged 9 commits into from
Feb 22, 2023

Conversation

rossbulat
Copy link

@rossbulat rossbulat commented Feb 21, 2023 •
edited
Loading

Updates weights for the added pool claims functions and logic.

  • bond_extra_reward has been renamed to bond_extra_other, and accounts for ClaimPermission check.
  • claim_payout now accounts for ClaimPermission check.
  • Added set_claim_permission weights.

@rossbulat
Copy link
Author

/cmd queue -v PATCH_substrate=12608 -c bench-bot $ runtime runtime pallet_nomination_pools

@rossbulat rossbulat marked this pull request as ready for review February 21, 2023 08:20
@rossbulat rossbulat mentioned this pull request Feb 21, 2023
Merged
@rossbulat
Copy link
Author

bot bench -v PATCH_substrate=12608 $ runtime polkadot-dev pallet_nomination_pools

@paritytech paritytech deleted a comment from command-bot bot Feb 21, 2023
@rossbulat
Copy link
Author

bot bench -v PATCH_substrate=12608 $ runtime kusama-dev pallet_nomination_pools

@rossbulat
Copy link
Author

bot bench -v PATCH_substrate=12608 $ runtime kusama-dev pallet_nomination_pools

@rossbulat
Copy link
Author

bot bench -v PATCH_substrate=12608 $ runtime westend-dev pallet_nomination_pools

@command-bot command-bot bot deleted a comment from paritytech-processbot bot Feb 21, 2023
@command-bot command-bot bot deleted a comment from paritytech-processbot bot Feb 22, 2023
@rossbulat
Copy link
Author

bot bench -v PATCH_substrate=12608 $ runtime kusama-dev pallet_nomination_pools

@command-bot
Copy link

command-bot bot commented Feb 22, 2023 •
edited
Loading

@rossbulat https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2426724 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime kusama-dev pallet_nomination_pools. Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 37-bb10eab9-e363-4c57-a164-286e018facf9 to cancel this command or bot cancel to cancel all commands in this pull request.

@paritytech paritytech deleted a comment from paritytech-processbot bot Feb 22, 2023
@command-bot
Copy link

command-bot bot commented Feb 22, 2023

@rossbulat Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime kusama-dev pallet_nomination_pools has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2426724 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2426724/artifacts/download.

@rossbulat rossbulat added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Feb 22, 2023
gpestana
gpestana approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@gpestana gpestana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

runtime/polkadot/src/weights/pallet_nomination_pools.rs
//! HOSTNAME: `runner-b3zmxxc-project-163-concurrent-0`, CPU: `Intel(R) Xeon(R) CPU @ 2.60GHz`
//! DATE: 2023-02-21, STEPS: `50`, REPEAT: `20`, LOW RANGE: `[]`, HIGH RANGE: `[]`
//! WORST CASE MAP SIZE: `1000000`
//! HOSTNAME: `runner-ehxwxxsd-project-163-concurrent-0`, CPU: `Intel(R) Xeon(R) CPU @ 2.60GHz`
//! EXECUTION: Some(Wasm), WASM-EXECUTION: Compiled, CHAIN: Some("polkadot-dev"), DB CACHE: 1024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems that the old weights were generated outside the bot machine 🤔

Copy link
Author

@rossbulat rossbulat Feb 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, they did look outdated, much less commenting and no mentioning of proofs. I imagine it was a much lower version being used of what is available now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the extra details were added to the template later afaik.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I guess they'll be replaced upon the runtime upgrade with the latest version also.

@ruseinov ruseinov self-requested a review February 22, 2023 10:57
ruseinov
ruseinov approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@ruseinov ruseinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the weights look legit!

@rossbulat
Copy link
Author

bot fmt

@command-bot
Copy link

command-bot bot commented Feb 22, 2023 •
edited
Loading

@rossbulat https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2427944 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 41-fa485861-e9ae-4f65-bd25-d351f795ccfd to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Feb 22, 2023

@rossbulat Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2427944 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2427944/artifacts/download.

@rossbulat
Copy link
Author

bot rebase

@paritytech-processbot
Copy link

Rebased

@paritytech-processbot
Copy link

Waiting for commit status.

kianenigma
kianenigma reviewed Feb 22, 2023
View reviewed changes
.cargo/config.toml
@@ -29,4 +29,4 @@ rustflags = [
"-Aclippy::needless_option_as_deref", # false positives
"-Aclippy::derivable_impls", # false positives
"-Aclippy::stable_sort_primitive", # prefer stable sort
]
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
]
]

@paritytech-processbot paritytech-processbot bot merged commit a1ceba0 into master Feb 22, 2023
@paritytech-processbot paritytech-processbot bot deleted the rb-pool-claim-weights branch February 22, 2023 13:05
ordian added a commit that referenced this pull request Mar 16, 2023
@ordian
Merge branch 'master' into ao-kusama-enable-dispute-slashes
7785be8 
* master: (98 commits)
  Ensure max_weight is assigned properly in AllowTopPaidExecutionFrom (#6787)
  Explicitly Handling ProvisionableData Cases (#6757)
  Companion for Substrate#12520 (#6730)
  Revert back to bare metal runners for weights generation (#6762)
  Improve XCM fuzzer (#6190)
  Corrected weight trader comment (#6752)
  clean up executed migrations (#6763)
  Remove state migration from westend runtime. (#6737)
  polkadot companion #12608 (Pools claim permissions) (#6753)
  Add Turboflakes bootnodes to Polkadot, Kusama and Westend (#6628)
  Companion for substrate#13284 (#6653)
  Companion for Substrate #13410: Introduce EnsureOrigin to democracy.propose (#6750)
  `BlockId` removal: `BlockBuilderProvider::new_block_at` (#6734)
  Companion PR for PR#13119 (#6683)
  Companion for Substrate#13411: frame/beefy: prune entries in set id session mapping (#6743)
  `BlockId` removal: refactor of runtime API (#6721)
  Fix auction bench (#6747)
  Use PVF code paired with executor params wherever possible (#6742)
  Retire `OldV1SessionInfo` (#6744)
  Companion for substrate #13121 - BEEFY Equivocations support (#6593)
  ...
@kiltbot kiltbot mentioned this pull request Apr 3, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ruseinov ruseinov ruseinov approved these changes

@gpestana gpestana gpestana approved these changes

@kianenigma kianenigma kianenigma approved these changes

@Ank4n Ank4n Ank4n approved these changes

@ggwpez ggwpez Awaiting requested review from ggwpez

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rossbulat @ruseinov @gpestana @kianenigma @Ank4n