Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Fix stalling dispute coordinator. #7125

Merged
merged 2 commits into from
Apr 25, 2023
Merged

Fix stalling dispute coordinator. #7125

merged 2 commits into from
Apr 25, 2023

Conversation

eskimor
Copy link
Member

@eskimor eskimor commented Apr 24, 2023

By limiting the amount of chain imports we do at a time.

@eskimor eskimor added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Apr 24, 2023
@tdimitrov
Copy link
Contributor

Could chain_import_backlog grow indefinitely? If dispute-coordinator can't catch up with the vote import this Vec could become quite big at some point or I'm missing something?

@eskimor
Copy link
Member Author

eskimor commented Apr 24, 2023

Could chain_import_backlog grow indefinitely? If dispute-coordinator can't catch up with the vote import this Vec could become quite big at some point or I'm missing something?

We process 8 blocks on each block import - so assuming we are not constantly skipping blocks it should be fine.

@vstakhov
Copy link
Contributor

Could chain_import_backlog grow indefinitely? If dispute-coordinator can't catch up with the vote import this Vec could become quite big at some point or I'm missing something?

Then it's probably stall vs OOM issue.

@eskimor eskimor merged commit a539c75 into master Apr 25, 2023
@eskimor eskimor deleted the rk-chain-import-backlog branch April 25, 2023 14:42
ordian added a commit that referenced this pull request Apr 26, 2023
* master:
  malus: dont panic on missing validation data (#6952)
  Offences Migration v1: Removes `ReportsByKindIndex` (#7114)
  Fix stalling dispute coordinator. (#7125)
  Fix rolling session window (#7126)
  [ci] Update buildah command and version (#7128)
  Bump assigned_slots params (#6991)
  XCM: Remote account converter (#6662)
  Rework `dispute-coordinator` to use `RuntimeInfo` for obtaining session information instead of `RollingSessionWindow` (#6968)
  Revert default proof size back to 64 KB (#7115)
ordian added a commit that referenced this pull request Apr 26, 2023
* master: (39 commits)
  malus: dont panic on missing validation data (#6952)
  Offences Migration v1: Removes `ReportsByKindIndex` (#7114)
  Fix stalling dispute coordinator. (#7125)
  Fix rolling session window (#7126)
  [ci] Update buildah command and version (#7128)
  Bump assigned_slots params (#6991)
  XCM: Remote account converter (#6662)
  Rework `dispute-coordinator` to use `RuntimeInfo` for obtaining session information instead of `RollingSessionWindow` (#6968)
  Revert default proof size back to 64 KB (#7115)
  update rocksdb to 0.20.1 (#7113)
  Reduce base proof size weight component to zero (#7081)
  PVF: Move PVF workers into separate crate (#7101)
  Companion for #13923 (#7111)
  update safe call filter (#7080)
  PVF: Don't dispute on missing artifact (#7011)
  XCM: Properly set the pricing for the DMP router (#6843)
  pvf: Update docs for PVF artifacts (#6551)
  Bump syn from 2.0.14 to 2.0.15 (#7093)
  Companion for substrate#13771 (#6983)
  Added Dwellir Nigeria bootnodes. (#7097)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants