Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Companion for substrate#14471 #7432

Merged
merged 11 commits into from
Jul 18, 2023
Merged

Companion for substrate#14471 #7432

merged 11 commits into from
Jul 18, 2023

Conversation

andresilva
Copy link
Contributor

No description provided.

@andresilva andresilva added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. C1-low PR touches the given topic and has a low impact on builders. D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited. labels Jun 27, 2023
@andresilva andresilva mentioned this pull request Jun 27, 2023
Merged
@paritytech-ci paritytech-ci requested review from a team June 27, 2023 14:22
@louismerlin louismerlin added D1-audited 👍 PR contains changes to critical logic that has been properly reviewed and externally audited. and removed D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited. labels Jul 11, 2023
@ggwpez
Dont use deprecated functions
c368b93 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Fixup
b9ce743 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Fix
7e29767 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Statuses failed for 1ffb683

@ggwpez
Copy link
Member

ggwpez commented Jul 18, 2023

Test failure here @andresilva in running_the_node_works_and_can_be_interrupted https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3212284

I will merge #7507 into here - otherwise there will be a companion deadlock again 🤦‍♂️

@ggwpez ggwpez mentioned this pull request Jul 18, 2023
Closed
@ggwpez
Update Substrate dep
2e6768a 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Copy link
Member

ggwpez commented Jul 18, 2023

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit 2c04bf7 into master Jul 18, 2023
4 checks passed
@paritytech-processbot paritytech-processbot bot deleted the andre/companion-14471 branch July 18, 2023 16:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@koute koute koute approved these changes

@franciscoaguirre franciscoaguirre franciscoaguirre approved these changes

@skunert skunert skunert approved these changes

@bkchr bkchr bkchr approved these changes

@davxy davxy davxy approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D1-audited 👍 PR contains changes to critical logic that has been properly reviewed and externally audited.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@andresilva @ggwpez @koute @franciscoaguirre @skunert @bkchr @davxy @louismerlin