Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update subwasm dependency to 0.19 #60

Merged
merged 4 commits into from
Feb 10, 2023

Conversation

ntn-x2
Copy link
Contributor

@ntn-x2 ntn-x2 commented Feb 9, 2023

Since the new subwasm version includes a feature we need, this PR bumps the subwasm dependency to the newly released version 0.19 which includes this feature.

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Co-authored-by: Chevdor <chevdor@users.noreply.github.com>
@ntn-x2 ntn-x2 requested a review from chevdor February 10, 2023 08:36
@ntn-x2
Copy link
Contributor Author

ntn-x2 commented Feb 10, 2023

Sorry, I probably made a bigger deal than it was 😄 I reverted to only change the subwasm value. All good now.

@ntn-x2
Copy link
Contributor Author

ntn-x2 commented Feb 10, 2023

@chevdor I guess it can be merged now 😁

@chevdor chevdor merged commit 8f991d6 into paritytech:master Feb 10, 2023
@ntn-x2
Copy link
Contributor Author

ntn-x2 commented Feb 10, 2023

When can I expect a Docker image with this fix to be released?

@chevdor
Copy link
Contributor

chevdor commented Feb 10, 2023

When the next release is finalized :)
I really can't give a date since I am waiting for features to land and I also don't have a date for those.

@ntn-x2
Copy link
Contributor Author

ntn-x2 commented Feb 13, 2023

@chevdor we kind of need this feature in rather sooner than later, and would like to avoid building our own image. There is no breaking change since subwasm is retro-compatible. Would it make sense to have a patch release with this change in?

@chevdor
Copy link
Contributor

chevdor commented Feb 14, 2023

One of the goal of srtool is to remain "stable" over time so I refrain from making new version unless there are excellent reasons to do so:

  • known vulnerability patched in newer version
  • relay chains runtimes no longer building on older compilers
  • compiler getting too old (usually >~ 6 months)
  • compiler bringing a neat new feature we want asap

While building your own image would be an option, I would recommend against it as users could no longer use the canonical version of srtool anymore.

Instead, I can think of 2 options and the later is IMO the best:

Swap subwasm using volume mapping

  • use the existing srtool
  • install the new subwasm version locally
  • "swap" the subwasm bin in the docker container using volume mapping

That would not break determinism and you could use the new features of subwasm already.

RISK: You may need to "swap" a few other scripts as well.

Localsubwasm run

You could even run the local (newer) subwasm after the srtool build. subwasm is integrated inside srtool as a helper and it makes it convenient to have it there but you don't have to use the subwasm version included in the srtool image so you could let srtool do its things using the older subwasm version, ignore the subwasm outputs, run the newer subwasm yourself and use those results. The execution time penalty will be negligible considering the time it takes to run srtool.

@ntn-x2
Copy link
Contributor Author

ntn-x2 commented Feb 15, 2023

@chevdor I see there are few images with a tag structure of, for instance, 1.66.0-0.9.24 and so on. These look like dev tags, but for us, for the time being, it would be totally ok. This is also not possible?

ntn-x2 added a commit to KILTprotocol/kilt-node that referenced this pull request May 2, 2023
## fixes KILTprotocol/ticket#2241
Generates metadata and publishes json value to s3 bucket
Sample here https://kilt-protocol.org/peregrine/peregrine-metadata.json

## Pending

- [x] SRTool Docker image that includes the new subwasm 0.19 with
support for `json+scale` output format. PR:
paritytech/srtool#60

---------

Co-authored-by: Tino Rusch <tino@kilt.io>
Co-authored-by: Antonio <antonio@kilt.io>
webguru9178 pushed a commit to webguru9178/kilt-node that referenced this pull request Jan 8, 2024
## fixes KILTprotocol/ticket#2241
Generates metadata and publishes json value to s3 bucket
Sample here https://kilt-protocol.org/peregrine/peregrine-metadata.json

## Pending

- [x] SRTool Docker image that includes the new subwasm 0.19 with
support for `json+scale` output format. PR:
paritytech/srtool#60

---------

Co-authored-by: Tino Rusch <tino@kilt.io>
Co-authored-by: Antonio <antonio@kilt.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants