test: silence unnecessary logging for tests (#916)

* silence the logger in test mode

* when test:watch set node_env

* silence middleware errors for testing

* lint

* clarification comments

package.json

@@ -35,7 +35,7 @@
     "start:log-rpc": "yarn run build && NODE_ENV=test yarn run main ",
     "dev": "tsc-watch --onSuccess \"yarn run main\"",
     "test": "NODE_ENV=test substrate-exec-jest --detectOpenHandles",
-    "test:watch": "substrate-exec-jest --watch",
+    "test:watch": "NODE_ENV=test substrate-exec-jest --watch",
     "test:cov": "NODE_ENV=test substrate-exec-jest --detectOpenHandles --coverage",
     "lint:e2e-tests": "cd e2e-tests && substrate-dev-run-lint",
     "build:e2e-tests": "substrate-exec-tsc --project e2e-tests/tsconfig.json",

src/logging/transports/consoleTransport.ts

@@ -68,6 +68,6 @@ export function consoleTransport(): transports.ConsoleTransportInstance {
 		handleExceptions: true,
 		format: format.combine(...transformers),
 		// Silence using `jest --silent`
-		silent: process.argv.indexOf('--silent') >= 0,
+		silent: process.env.NODE_ENV === 'test',
 	});
 }

src/middleware/error/errorMiddleware.spec.ts

@@ -29,6 +29,11 @@ const errorMiddlewareCatchesErrWithStatus =
 	catchesErrWithStatus(errorMiddleware);
 
 describe('errorMiddleware', () => {
+	// Necessary since the consolveOverride is called after the getter for the logger is launced
+	beforeAll(() => {
+		jest.spyOn(console, 'log').mockImplementation(() => ({}));
+	});
+
 	errorMiddlewareCallsNextWithErr('ILegacyError', {
 		error: 'legacy error',
 		statusCode: 500,

src/middleware/error/httpErrorMiddleware.spec.ts

@@ -31,6 +31,11 @@ const httpErrorMiddlewareCatchesErrWithStatus =
 	catchesErrWithStatus(httpErrorMiddleware);
 
 describe('httpErrorMiddleware', () => {
+	// Necessary since the consolveOverride is called after the getter for the logger is launced
+	beforeAll(() => {
+		jest.spyOn(console, 'log').mockImplementation(() => ({}));
+	});
+
 	httpErrorMiddlewareCallsNextWithErr('Error', new Error('This is an error'));
 
 	httpErrorMiddlewareCallsNextWithErr('IBasicError', {

src/middleware/error/internalErrorMiddleware.spec.ts

@@ -25,6 +25,11 @@ const internalErrorMiddlewareCatchesErrWithResponse = catchesErrWithResponse(
 );
 
 describe('internalErrorMiddleware', () => {
+	// Necessary since the consolveOverride is called after the getter for the logger is launced
+	beforeAll(() => {
+		jest.spyOn(console, 'log').mockImplementation(() => ({}));
+	});
+
 	internalErrorMiddlewareCatchesErrWithResponse(
 		'ITxLegacyError',
 		{

src/middleware/error/legacyErrorMiddleware.spec.ts

@@ -33,6 +33,11 @@ const legacyErrorMiddlewareCatchesErrWithResponse = catchesErrWithResponse(
 );
 
 describe('legacyErrorMiddleware', () => {
+	// Necessary since the consolveOverride is called after the getter for the logger is launced
+	beforeAll(() => {
+		jest.spyOn(console, 'log').mockImplementation(() => ({}));
+	});
+
 	legacyErrorMiddlewareCallsNextWithErr('Error', new Error('This is an error'));
 
 	legacyErrorMiddlewareCallsNextWithErr(

src/middleware/error/txErrorMiddleware.spec.ts

@@ -29,6 +29,11 @@ const txErrorMiddlewareCatchesErrWithResponse =
 	catchesErrWithResponse(txErrorMiddleware);
 
 describe('txErrorMiddleware', () => {
+	// Necessary since the consolveOverride is called after the getter for the logger is launced
+	beforeAll(() => {
+		jest.spyOn(console, 'log').mockImplementation(() => ({}));
+	});
+
 	txErrorMiddlewareCallsNextWithErr('Error', new Error('This is an error'));
 
 	txErrorMiddlewareCallsNextWithErr(