Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

there is no migration path for noMeta migration #1274

Closed
xlc opened this issue Apr 27, 2023 · 2 comments · Fixed by #1275
Closed

there is no migration path for noMeta migration #1274

xlc opened this issue Apr 27, 2023 · 2 comments · Fixed by #1275

Comments

@xlc
Copy link
Contributor

xlc commented Apr 27, 2023

When noMeta is used, it will complain and ask for migration. But migrate to what?
@TarikGul
Copy link
Member

This is old legacy code from Pre V14 metadata. It was replaced with the metadata query param. Its long overdue for completely removing noMeta. Thanks for bringing this up, as its been lost in the queue for a while. I'll get this in tomorrow to finally finish this.

The expected behavior will be: metadata query param takes in two values scale or json for the format of the metadata, and if the query param is not inputted the field wont be there.

The controller code can be seen here.

@TarikGul TarikGul mentioned this issue Apr 27, 2023
Merged
@TarikGul
Copy link
Member

The migration on this was sloppy looking over the previous code being that if you wanted no metadata in the response you still have to input the noMeta query param. This should be completely solved with the above PR. Thanks for bringing this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix!: remove noMeta query param from /transaction/materials paritytech/substrate-api-sidecar
2 participants
@xlc @TarikGul