Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: remove noMeta query param from /transaction/materials #1275

Merged
merged 4 commits into from
May 1, 2023

Conversation

TarikGul
Copy link
Member

@TarikGul TarikGul commented Apr 27, 2023

Summary

This is a long overdue change where noMeta is removed from /transaction/materials. It will be fully deprecated.

Changes

noMeta removed.

metadata is the source of truth for the metadata key in the response. When the metadata field is not present, no metadata will be returned. There are two options for the metadata query param.

  1. json - decoded metadata in json format.
  2. scale - scale encoded metadata format.

closes: #1274

@TarikGul TarikGul requested a review from a team as a code owner April 27, 2023 14:07
Copy link
Collaborator

@marshacb marshacb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@TarikGul TarikGul merged commit 1d20501 into master May 1, 2023
@TarikGul TarikGul deleted the tarik-remove-nometa branch May 1, 2023 16:52
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

there is no migration path for noMeta migration
2 participants