Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tests for Staking Payouts after Historic Support implementation #1423

Open
Imod7 opened this issue Apr 1, 2024 · 0 comments
Open

Add Tests for Staking Payouts after Historic Support implementation #1423

Imod7 opened this issue Apr 1, 2024 · 0 comments

Comments

@Imod7
Copy link
Contributor

Imod7 commented Apr 1, 2024

Proposed Change or Idea
The rapid implementation of #1397 was needed by urgent requirements so no tests were included initially. It is important to add proper tests to ensure that the /accounts/{accountId}/staking-payouts endpoint works as expected after the historic support implementation. That way in the future we can avoid more fixes like #1415 and #1422

Example tests

  • Staking Payouts in Kusama chain for :
    • eras < 518
    • eras right in the change of 518 (special cases)
    • era = 0
  • Staking Payouts in Polkadot (or another chain) chain to ensure that general functionality (not related to historic support) is not affected
  • Tests that combine the available query parameters: era, depth, unclaimedOnly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant