fix: add Kusama chain check in historic blocks #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TarikGul
reviewed
Mar 20, 2024
| @@ -104,17 +104,18 @@ export default class AccountsStakingPayoutsController extends AbstractController | |||
| const earlyErasBlockInfo: IEarlyErasBlockInfo = kusamaEarlyErasBlockInfo; | |||
| let hash = await this.getHashFromAt(at); | |||
| let apiAt = await this.api.at(hash); | |||
| const runtimeInfo = await this.api.rpc.state.getRuntimeVersion(hash); | |||
There was a problem hiding this comment.
Let's right a variable here that is:
const isKusama = runtimeInfo.specName.toString().toLowerCase() === 'kusama';This should clean the rest up a bit
TarikGul
reviewed
Mar 20, 2024
TarikGul
reviewed
Mar 20, 2024
| ? historicApi.query.staking.validators(validatorId) | ||
| : historicApi.query.staking.erasValidatorPrefs(era, validatorId); | ||
| commissionPromise = | ||
| ancient && specName.toLowerCase() === 'kusama' |
There was a problem hiding this comment.
We can do the isKusama variable here as well if you'd like.
TarikGul
approved these changes
Mar 20, 2024
bee344
reviewed
Mar 20, 2024
marshacb
approved these changes
Mar 20, 2024
bee344
reviewed
Mar 20, 2024
Co-authored-by: Alberto Nicolas Penayo <74352651+bee344@users.noreply.github.com>
This was referenced Apr 1, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a check to determine if we are connected in the Kusama chain, as the calculations are
Kusamaspecific.Credits & Thanks