Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get Shiden 1500094 fee failed #989

Closed
LXHLeaner opened this issue Jul 20, 2022 · 3 comments · Fixed by #990 or #997
Closed

get Shiden 1500094 fee failed #989

LXHLeaner opened this issue Jul 20, 2022 · 3 comments · Fixed by #990 or #997
Labels
I2 - Bug 🐜 Sidecar has a bug

Comments

@LXHLeaner
Copy link

get the dataArr[0] is WuSTANhkhikbhfsifpeTW3dHvb4UotErkCCs7sLxxGfg57z
get the dataArr[1] is 0x000000000000000000119e2433bf11f3.

and new BN(fee) is err

// The difference between values is 00.00001% or less so they are alike.
if (this.areFeesSimilar(new BN(fee), partialFee)) {
return {
partialFee: fee.toString(),
};
}

@TarikGul
Copy link
Member

Thanks for reporting this, will get this fixed. Yea unfortunately every parachain structures their data a little differently so it might not be a one for all solution. But I will get the type check sorted.

@LXHLeaner
Copy link
Author

It is have problem. at height: 1500099

private sanitizeFee(fee: string): string {
if (isHex(fee)) {
const numFee = hexToNumber(fee);
return numFee.toString(10);
}

	return fee;
}

input:
fee = 0x00000000000000000025aa5276c6653d

output:
2022-07-29 14:56:43 info: WAyw2mtxkRk9vjmwBdGivFduhVmGEeCH8JAXVmREzku92a8
2022-07-29 14:57:07 error: getTxList Error: Number can only safely store up to 53 bits

@TarikGul
Copy link
Member

@LXHLeaner Thanks for bringing this up, will get a fix out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I2 - Bug 🐜 Sidecar has a bug
Projects
None yet
2 participants