fix(feeByEvent): sanitize fee for hex values #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsdw
approved these changes
Jul 21, 2022
Xanewok
reviewed
Jul 21, 2022
| @@ -532,7 +532,9 @@ export class BlocksService extends AbstractService { | |||
| if (withdrawEvent.length > 0 && withdrawEvent[0].data) { | |||
| const dataArr = withdrawEvent[0].data.toJSON(); | |||
| if (Array.isArray(dataArr)) { | |||
| const fee = (dataArr as Array<number>)[dataArr.length - 1]; | |||
| const fee = this.sanitizeFee( | |||
| (dataArr as Array<string>)[dataArr.length - 1] | |||
There was a problem hiding this comment.
Did the shape change here or do we want to have it seen as string for the sanitizeFee/isHex call?
There was a problem hiding this comment.
So the shape was inaccurately type casted for fees (technically number or string work here for BN.js but I changed it to its proper type to be more accurate). The type returned from .toJSON() should be a string, because any u128/u64 value interpreted by polkadot-js will be returned as a string.
lexnv
approved these changes
Jul 27, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #989
When a fee is represented as a hex value, sanitize the fee correctly.