Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove fee integration guide #1010

Merged
merged 3 commits into from
Sep 3, 2022
Merged

docs: remove fee integration guide #1010

merged 3 commits into from
Sep 3, 2022

Conversation

TarikGul
Copy link
Member

@TarikGul TarikGul commented Aug 5, 2022

Remove the fee integration guide as CalcFee is not used anymore.

Fix up the readme some more.

@TarikGul TarikGul requested a review from a team as a code owner August 5, 2022 13:38
@TarikGul TarikGul self-assigned this Aug 5, 2022
@TarikGul TarikGul added the I5 - Documentation 📖 Documentation needs fixes or additions label Aug 5, 2022
Copy link
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Do we want to add anything w.r.t the new function?

@TarikGul
Copy link
Member Author

Looks good! Do we want to add anything w.r.t the new function?

Yes absolutely I will update this to include calc_partial_fee.

@TarikGul
Copy link
Member Author

Once #1017 is merged, I will update these docs agains properly with the fee method we use.

@TarikGul TarikGul merged commit 66f57b5 into master Sep 3, 2022
@TarikGul TarikGul deleted the tarik-remove-guide branch September 3, 2022 17:22
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I5 - Documentation 📖 Documentation needs fixes or additions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants