Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add TransactionPayment::TransactionPaidFee support #1040

Merged
merged 4 commits into from
Sep 6, 2022
Merged

fix: add TransactionPayment::TransactionPaidFee support #1040

merged 4 commits into from
Sep 6, 2022

Conversation

TarikGul
Copy link
Member

@TarikGul TarikGul commented Sep 1, 2022 •
edited
Loading

closes: #756 #971

This is a continuation of #1017. For all future blocks that have the event TransactionPayment::TransactionPaidFee we will retrieve the fee directly from the event.

Adds a fromEvent dispatchFeeType.

@TarikGul TarikGul requested a review from a team as a code owner September 1, 2022 00:37
@TarikGul TarikGul self-assigned this Sep 1, 2022
niklasad1
niklasad1 approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TarikGul TarikGul merged commit 108a93b into master Sep 6, 2022
@TarikGul TarikGul deleted the tarik-transactionPaidFee branch September 6, 2022 14:56
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsdw jsdw jsdw left review comments

@niklasad1 niklasad1 niklasad1 approved these changes

@lexnv lexnv lexnv approved these changes

Assignees

@TarikGul TarikGul

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fetch tx fee from onchain events
4 participants
@TarikGul @jsdw @niklasad1 @lexnv